Skip to content

🌱Sort volumes by targetID #1340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lubronzhan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🌱Sort volumes by targetID #1340

lubronzhan wants to merge 1 commit into from

Conversation

@lubronzhan
Copy link
Contributor

@lubronzhan lubronzhan commented Nov 24, 2025 •
edited
Loading

What does this PR do, and why is it needed?

Sort vm status by TargetID instead of UUID

  • UUID is less human readable than TargetID
  • Sort by TargetID if VMShareDisks is enabled

Are there any special notes for your reviewer:
Testing:
Before code
Sorted by diskUUID, not very helpful.

    volumes:
    - attached: true
      controllerBusNumber: 0
      controllerType: SCSI
      diskUUID: 6000C290-0790-cd59-1732-68395838aef1
      limit: 5Mi
      name: vol-1
      requested: 5Mi
      type: Managed
      unitNumber: 2
      used: "912"
    - attached: true
      controllerBusNumber: 0
      controllerType: SCSI
      diskUUID: 6000C291-8e2d-0478-c3f6-6d7ef72587fb
      limit: 16Gi
      name: test-vm-8e272c8e
      requested: 16Gi
      type: Classic
      unitNumber: 0
      used: "922747421"
    - attached: true
      controllerBusNumber: 0
      controllerType: SCSI
      diskUUID: 6000C291-9e47-13d5-56ea-44cb934c7524
      limit: 5Mi
      name: vol-0
      requested: 5Mi
      type: Managed
      unitNumber: 1
      used: "912"
    - attached: true
      controllerBusNumber: 0
      controllerType: SCSI
      diskUUID: 6000C29a-ac42-6cef-a808-61c7d8f868ed
      limit: 5Mi
      name: vol-2
      requested: 5Mi
      type: Managed
      unitNumber: 3
      used: "918"
    zone: domain-c36

After code change, sorted by target ID

    volumes:
    - attached: true
      controllerBusNumber: 0
      controllerType: SCSI
      diskUUID: 6000C291-8e2d-0478-c3f6-6d7ef72587fb
      limit: 16Gi
      name: test-vm-8e272c8e
      requested: 16Gi
      type: Classic
      unitNumber: 0
      used: "922747421"
    - attached: true
      controllerBusNumber: 0
      controllerType: SCSI
      diskUUID: 6000C291-9e47-13d5-56ea-44cb934c7524
      limit: 5Mi
      name: vol-0
      requested: 5Mi
      type: Managed
      unitNumber: 1
      used: "912"
    - attached: true
      controllerBusNumber: 0
      controllerType: SCSI
      diskUUID: 6000C290-0790-cd59-1732-68395838aef1
      limit: 5Mi
      name: vol-1
      requested: 5Mi
      type: Managed
      unitNumber: 2
      used: "912"
    - attached: true
      controllerBusNumber: 0
      controllerType: SCSI
      diskUUID: 6000C29a-ac42-6cef-a808-61c7d8f868ed
      limit: 5Mi
      name: vol-2
      requested: 5Mi
      type: Managed
      unitNumber: 3
      used: "918"
    - attached: true
      controllerBusNumber: 1
      controllerType: SCSI
      diskUUID: 6000C29c-73db-ce87-1903-26791dc32384
      limit: 5Mi
      name: vol-3
      requested: 5Mi
      type: Managed
      unitNumber: 1
      used: "858"
    zone: domain-c36

@lubronzhan lubronzhan changed the title 🌱Sort voluems by targetID 🌱Sort volumes by targetID Nov 24, 2025
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Nov 24, 2025
@lubronzhan lubronzhan requested a review from akutz November 27, 2025 02:04
@lubronzhan lubronzhan force-pushed the topic/lubron/sort_volume_by_target_id branch from 3734712 to a2a5231 Compare November 27, 2025 02:06
@github-actions
Copy link

github-actions bot commented Nov 27, 2025

Code Coverage

Package Line Rate Health
github.com/vmware-tanzu/vm-operator/controllers/contentlibrary/clustercontentlibraryitem 67% ❌
github.com/vmware-tanzu/vm-operator/controllers/contentlibrary/contentlibraryitem 67% ❌
github.com/vmware-tanzu/vm-operator/controllers/contentlibrary/utils 46% ❌
github.com/vmware-tanzu/vm-operator/controllers/infra/capability/configmap 92% ✔
github.com/vmware-tanzu/vm-operator/controllers/infra/capability/crd 100% ✔
github.com/vmware-tanzu/vm-operator/controllers/infra/configmap 75% ❌
github.com/vmware-tanzu/vm-operator/controllers/infra/node 77% ❌
github.com/vmware-tanzu/vm-operator/controllers/infra/secret 76% ❌
github.com/vmware-tanzu/vm-operator/controllers/infra/validatingwebhookconfiguration 87% ➖
github.com/vmware-tanzu/vm-operator/controllers/infra/zone 73% ❌
github.com/vmware-tanzu/vm-operator/controllers/storageclass 95% ✔
github.com/vmware-tanzu/vm-operator/controllers/storagepolicyquota 98% ✔
github.com/vmware-tanzu/vm-operator/controllers/util/encoding 73% ❌
github.com/vmware-tanzu/vm-operator/controllers/virtualmachine/storagepolicyusage 96% ✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachine/virtualmachine 69% ❌
github.com/vmware-tanzu/vm-operator/controllers/virtualmachine/volume 87% ➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachine/volumebatch 85% ➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineclass 73% ❌
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinegroup 89% ✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinegrouppublishrequest 88% ➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineimagecache 89% ➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinepublishrequest 83% ➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinereplicaset 67% ❌
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineservice 83% ➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachineservice/providers 92% ✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinesetresourcepolicy 81% ➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinesnapshot 92% ✔
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinewebconsolerequest 72% ❌
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinewebconsolerequest/v1alpha1 72% ❌
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinewebconsolerequest/v1alpha1/conditions 88% ➖
github.com/vmware-tanzu/vm-operator/controllers/virtualmachinewebconsolerequest/v1alpha1/patch 78% ❌
github.com/vmware-tanzu/vm-operator/controllers/vspherepolicy/policyevaluation 93% ✔
github.com/vmware-tanzu/vm-operator/pkg/bitmask 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/builder 93% ✔
github.com/vmware-tanzu/vm-operator/pkg/conditions 90% ✔
github.com/vmware-tanzu/vm-operator/pkg/config 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/config/capabilities 98% ✔
github.com/vmware-tanzu/vm-operator/pkg/config/env 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/context 22% ❌
github.com/vmware-tanzu/vm-operator/pkg/context/generic 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/context/operation 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/crd 77% ❌
github.com/vmware-tanzu/vm-operator/pkg/errors 76% ❌
github.com/vmware-tanzu/vm-operator/pkg/exit 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/log 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/mem 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/patch 78% ❌
github.com/vmware-tanzu/vm-operator/pkg/prober 89% ➖
github.com/vmware-tanzu/vm-operator/pkg/prober/probe 90% ✔
github.com/vmware-tanzu/vm-operator/pkg/prober/worker 77% ❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere 75% ❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/clustermodules 73% ❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/config 88% ➖
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/contentlibrary 76% ❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/credentials 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/network 81% ➖
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/placement 74% ❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/session 55% ❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/storage 44% ❌
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/upgrade/virtualmachine 96% ✔
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/vcenter 85% ➖
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/virtualmachine 86% ➖
github.com/vmware-tanzu/vm-operator/pkg/providers/vsphere/vmlifecycle 72% ❌
github.com/vmware-tanzu/vm-operator/pkg/record 87% ➖
github.com/vmware-tanzu/vm-operator/pkg/topology 91% ✔
github.com/vmware-tanzu/vm-operator/pkg/util 71% ❌
github.com/vmware-tanzu/vm-operator/pkg/util/cloudinit 89% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/cloudinit/validate 91% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/image 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/kube 94% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/kube/cource 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/kube/internal 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/kube/proxyaddr 73% ❌
github.com/vmware-tanzu/vm-operator/pkg/util/kube/spq 99% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/linuxprep 97% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/netplan 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/nil 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/ovfcache 75% ❌
github.com/vmware-tanzu/vm-operator/pkg/util/ovfcache/internal 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/paused 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/ptr 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/resize 98% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/sysprep 98% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/vmopv1 89% ➖
github.com/vmware-tanzu/vm-operator/pkg/util/volumes 92% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/vsphere/client 66% ❌
github.com/vmware-tanzu/vm-operator/pkg/util/vsphere/datastore 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/vsphere/library 96% ✔
github.com/vmware-tanzu/vm-operator/pkg/util/vsphere/vm 79% ❌
github.com/vmware-tanzu/vm-operator/pkg/util/vsphere/watcher 85% ➖
github.com/vmware-tanzu/vm-operator/pkg/vmconfig 95% ✔
github.com/vmware-tanzu/vm-operator/pkg/vmconfig/anno2extraconfig 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/vmconfig/bootoptions 88% ➖
github.com/vmware-tanzu/vm-operator/pkg/vmconfig/cdrom 88% ➖
github.com/vmware-tanzu/vm-operator/pkg/vmconfig/crypto 91% ✔
github.com/vmware-tanzu/vm-operator/pkg/vmconfig/diskpromo 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/vmconfig/policy 96% ✔
github.com/vmware-tanzu/vm-operator/pkg/vmconfig/virtualcontroller 85% ➖
github.com/vmware-tanzu/vm-operator/pkg/vmconfig/volumes/unmanaged/backfill 100% ✔
github.com/vmware-tanzu/vm-operator/pkg/vmconfig/volumes/unmanaged/register 96% ✔
github.com/vmware-tanzu/vm-operator/pkg/webconsolevalidation 100% ✔
github.com/vmware-tanzu/vm-operator/services/vm-watcher 85% ➖
github.com/vmware-tanzu/vm-operator/webhooks/common 98% ✔
github.com/vmware-tanzu/vm-operator/webhooks/persistentvolumeclaim/validation 95% ✔
github.com/vmware-tanzu/vm-operator/webhooks/unifiedstoragequota/validation 88% ➖
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachine/mutation 86% ➖
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachine/validation 95% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineclass/mutation 62% ❌
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineclass/validation 89% ➖
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinegroup/mutation 87% ➖
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinegroup/validation 92% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinegrouppublishrequest/mutation 86% ➖
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinegrouppublishrequest/validation 88% ➖
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinepublishrequest/validation 93% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinereplicaset/validation 90% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineservice/mutation 67% ❌
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachineservice/validation 92% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinesetresourcepolicy/validation 89% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinesnapshot/mutation 83% ➖
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinesnapshot/validation 89% ➖
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinewebconsolerequest/v1alpha1/validation 92% ✔
github.com/vmware-tanzu/vm-operator/webhooks/virtualmachinewebconsolerequest/validation 92% ✔
Summary 83% (17615 / 21349) ➖

Minimum allowed line rate is 79%

@lubronzhan lubronzhan requested a review from bryanv December 3, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akutz akutz Awaiting requested review from akutz

@bryanv bryanv Awaiting requested review from bryanv

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

size/L Denotes a PR that changes 100-499 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@lubronzhan