🌱 Improve build/test times in Github actions #1226
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akutz
force-pushed
the
feature/go-test-cache
branch
2 times, most recently
from
be70d9b to
60a63e0
Compare
This patch seeks to improve the amount of time required to build/test this project when run via Github actions. This change: * Disables the setup-go action's native caching mechanism * Introduces two, explicit caching actions for caching the Go build/test cache and Go mod cache directories separately because the Go build/test cache should be cached whenever the sources change. However, the Go mod cache should only be cached whenever the module definitions change. * Resets the mtime of checked out Go sources based on a file's calculated hash due to the way Go's test caching algoritm works via golang/go#58571.
akutz
force-pushed
the
feature/go-test-cache
branch
from
60a63e0 to
468b1d7
Compare
Minimum allowed line rate is |
lubronzhan
approved these changes
Oct 7, 2025
Contributor
lubronzhan
left a comment
lubronzhan
left a comment
There was a problem hiding this comment.
LGTM! Interesting.
Just curious is the target "restore" accurate enough considering how the cli works. Maybe a comment on the Makefile target would be easier for the reader to understand?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
This patch seeks to improve the amount of time required to build/test this project when run via Github actions. This change:
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes
NAAre there any special notes for your reviewer:
Please add a release note if necessary: