Improvements for extraction tools (vmap/mmap) #3192

schell244 · 2026-01-02T17:52:58Z

🍰 Pullrequest

The extractor was logging warnings for models referenced in DBC files that don't actually exist in MPQ archives.
Added MPQFileExists() check before attempting to open model files, so only actual extraction failures are reported.

Also removed the misleading "A few of these warnings are expected"
message since warnings now indicate real problems.

Add MPQFileExists to prevent false warning messages
Improve single tile mmap building
Add fallback logic for model paths with space/underscore variants
~~Add interactive prompts for vmap resolution~~
Add "Press enter to close" prompts to prevent console from closing on error
fix tileY,tileX filename order in IntermediateValues.cpp (revert previous change)
buildSingleTile now always rebuilds the tile (overwrite existing)
improve .mmap connect command to record offmesh entries
added new offmesh to fix path between Mr. Smite bridge <-> ship

Proof

None

Issues

None

How2Test

None

Todo / Checklist

None

mserajnik · 2026-01-03T14:51:09Z

Add interactive prompts for vmap resolution
Add "Press enter to close" prompts to prevent console from closing on error

Will this still allow for running the extraction unsupervised/without manual input? That's important to me for scripting purposes. 😄

mserajnik · 2026-01-03T15:02:24Z

contrib/vmap_extractor/vmapextract/vmapexport.cpp

-    bool highRes = preciseVectorData;
-    std::string userInput;
-    std::cout << "Extract vmaps with high resolution? [y/n]" << std::endl;
-    std::getline(std::cin, userInput);
-    highRes = userInput.empty() || userInput.compare("y") == 0;
-    std::cout << "High resolution = " << highRes << std::endl;
-    std::cout << "Press enter to start extracting vmaps." << std::endl;
-    std::cout << "=====================================" << std::endl;
-    std::cin.get();
-
-    // Overwrite due to user input
-    preciseVectorData = highRes;
-


If you want to keep the prompts, to me it would also be fine to introduce a flag --non-interactive or something instead to be able to skip them.

Thanks for pointing that out. I might just open a second PR, adding promts for both maps/vmaps similar to how it's currently done in the mmap tool 👍 (diff is already big enough here 😅)

Would be very much appreciated if you want to give it a try 😇. A good point to check is .go c Glutton and see if he manages to walk through his 'narrow passage' – when Razorfen Leanto03 was broken, he just disappeared in the walls instead.

I'm unfortunately on vacation and don't really have the time to test it, but I'll gladly give it a spin when I'm back next week!

Thanks and no worries, enjoy your vacation!🎉

mserajnik · 2026-01-06T19:08:01Z

Nice work with the Deadmines fix! Looking forward to give that a try.

Do you happen to have an idea how any of the following other pathing bugs could be fixed?
I assume offmesh connections won't be the solution in these cases.

Seemingly invisible walls in RFD (duplicate issue exists here)
Seemingly invisible wall in Azurelode Mine (my comment, didn't want to create a new issue)
Pathing issue with a shipwreck in Wetlands

schell244 · 2026-01-06T20:19:06Z

"RFD invisible wall issue" could already be fixed, since the patch that fixed parsing of “razorfen leanto03”, but have not checked that certain spot yet.

Using offmesh connections is the simplest way of patching up broken mmap spots without having to touch the overall logic. You can "force" a path between two points, which you declare in offmesh.txt.
The easiest way to record it is using .mmap connect (records point 1), then move to the point where you want to create a connection, run .mmap connect again, and it will create an offmesh entry in a file called offmesh_connections.txt, which you can then copy to the actual offmesh file that the mmap generator reads from. Afterwards just rebuild the tile where you added the path patch.

A useful command to check NPC pathing between you and another NPC is .mmap path - it will spawn those blue spirit waypoint NPCs along the path from your character to the selected NPC. If there is a "hole" or problem in between, the spawned waypoints will show that. Also what works well is spawning a pet and watching if it takes weird extra walks at certain spots.

ShiyoKozuki · 2026-01-06T20:42:08Z

Nice work with the Deadmines fix! Looking forward to give that a try.

Do you happen to have an idea how any of the following other pathing bugs could be fixed? I assume offmesh connections won't be the solution in these cases.
* [Seemingly invisible walls in RFD](https://github.com/vmangos/core/issues/2516) (duplicate issue exists [here](https://github.com/vmangos/core/issues/2549))

* [Seemingly invisible wall in Azurelode Mine](https://github.com/vmangos/core/issues/2516#issuecomment-3440207582) (my comment, didn't want to create a new issue)

* [Pathing issue with a shipwreck in Wetlands](https://github.com/vmangos/core/issues/2858)

Gnomergan also has pathing issues in the big room on the elevator after Crowd Pummeler 9-60. The big room that has the elevator, but at the bottom level.

ratkosrb · 2026-01-07T08:00:04Z

contrib/mmap/src/MapBuilder.cpp

-        printf("Done.");
+
+        char mapFileName[255];
+        sprintf(mapFileName, "mmaps/%03u.mmap", mapID);


why are you formatting this separately and not in the printf

ratkosrb · 2026-01-07T08:00:43Z

contrib/mmap/src/MapBuilder.cpp

+        processQueuedTiles();
+
+        char outputFileName[255];
+        sprintf(outputFileName, "mmaps/%03u%02u%02u.mmtile", mapID, tileY, tileX);


again why not do this inside the printf

schell244 force-pushed the vmap_fix branch from f54c89f to 95d30f4 Compare January 3, 2026 14:43

schell244 changed the title ~~Restore fixedName assignment in ExtractSingleModel~~ Improve vmap extraction tool Jan 3, 2026

mserajnik reviewed Jan 3, 2026

View reviewed changes

schell244 changed the title ~~Improve vmap extraction tool~~ Improvements for extraction tools (vmap/mmap) Jan 3, 2026

schell244 force-pushed the vmap_fix branch from e39ccb3 to 6382cff Compare January 6, 2026 14:37

Improvements for extraction tools (vmap/mmap)

c815238

schell244 force-pushed the vmap_fix branch from 6382cff to c815238 Compare January 6, 2026 17:47

Fix path in The Deadmines - Mr. Smite bridge <-> ship

1a64a00

ratkosrb reviewed Jan 7, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Improvements for extraction tools (vmap/mmap) #3192

Improvements for extraction tools (vmap/mmap) #3192

Uh oh!

schell244 commented Jan 2, 2026 •

edited

Loading

Uh oh!

mserajnik commented Jan 3, 2026

Uh oh!

mserajnik Jan 3, 2026

Uh oh!

schell244 Jan 3, 2026 •

edited

Loading

Uh oh!

schell244 Jan 3, 2026

Uh oh!

mserajnik Jan 5, 2026

Uh oh!

schell244 Jan 6, 2026

Uh oh!

mserajnik commented Jan 6, 2026

Uh oh!

schell244 commented Jan 6, 2026

Uh oh!

ShiyoKozuki commented Jan 6, 2026

Uh oh!

ratkosrb Jan 7, 2026

Uh oh!

ratkosrb Jan 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Improvements for extraction tools (vmap/mmap) #3192

Are you sure you want to change the base?

Improvements for extraction tools (vmap/mmap) #3192

Uh oh!

Conversation

schell244 commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🍰 Pullrequest

Proof

Issues

How2Test

Todo / Checklist

Uh oh!

mserajnik commented Jan 3, 2026

Uh oh!

mserajnik Jan 3, 2026

Choose a reason for hiding this comment

Uh oh!

schell244 Jan 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

schell244 Jan 3, 2026

Choose a reason for hiding this comment

Uh oh!

mserajnik Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

schell244 Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

mserajnik commented Jan 6, 2026

Uh oh!

schell244 commented Jan 6, 2026

Uh oh!

ShiyoKozuki commented Jan 6, 2026

Uh oh!

ratkosrb Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

ratkosrb Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

schell244 commented Jan 2, 2026 •

edited

Loading

schell244 Jan 3, 2026 •

edited

Loading