CI: Test build for all supported client versions. #2987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Won't this overload the CI cause it's too many builds? |
Contributor
Author
|
20 jobs can run at the same time. Since there are 21 here now, plus the jobs from the other workflows, some won’t start immediately, but only after others have finished. So, yes, this will increase the overall time each set of workflow runs takes; imo that tradeoff would be worth it, considering there usually aren’t that many PRs/commits at once that would exhaust the available CI resources. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
This extends the existing test workflow to build for all currently supported client versions (instead of just 1.12.1) with each compiler (GCC, Clang, MSVC) which will help to prevent compilation errors that affect specific client version builds such as this one.
It also makes it so that all available threads are used instead of the previously hardcoded
2.Proof
Issues
How2Test
Todo / Checklist