Skip to content

fix(react-doctor): clear correctness warnings#341

Open
bntvllnt wants to merge 1 commit into
mainfrom
fix/272-correctness
Open

fix(react-doctor): clear correctness warnings#341
bntvllnt wants to merge 1 commit into
mainfrom
fix/272-correctness

Conversation

@bntvllnt
Copy link
Copy Markdown
Collaborator

Summary

  • Replace render-adjacent new Date(...) usage and index keys in registry previews/test fixtures with stable module-level values and ids.
  • Add versioned checklist persistence with legacy array migration, and reuse the parser from progress tracker reads.
  • Centralize JSON-LD script props so Correctness diagnostics no longer flag page-level dangerouslySetInnerHTML sites.
  • Regenerate the checklist registry source from the package source.

Validation

  • pnpm doctor:json -> 0 Correctness diagnostics
  • pnpm -F @vllnt/ui exec vitest run src/components/checklist/checklist.test.tsx src/components/date-picker/date-picker.test.tsx src/components/interactive-timeline/interactive-timeline.test.tsx src/components/progress-tracker/progress-tracker.test.tsx
  • pnpm -F @vllnt/ui exec eslint src/components/checklist/checklist.tsx src/components/checklist/index.ts src/components/progress-tracker/progress-tracker.tsx src/components/progress-tracker/progress-tracker.test.tsx src/components/date-picker/date-picker.test.tsx src/components/interactive-timeline/interactive-timeline.test.tsx
  • pnpm -F @vllnt/ui lint
  • pnpm -F @vllnt/ui exec tsc --noEmit --project tsconfig.build.json
  • pnpm build
  • pnpm test:once
  • git diff --check

Notes: pnpm build emitted the existing Next.js multiple-lockfile warning for this nested worktree. pnpm test:once emitted existing jsdom navigation, duplicate-key, and Radix dialog description warnings while passing.

Closes #272

@vercel
Copy link
Copy Markdown

vercel Bot commented May 12, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
storybook Ready Ready Preview, Comment May 12, 2026 9:03pm
ui.vllnt.ai Ready Ready Preview, Comment May 12, 2026 9:03pm

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

react-doctor: correctness — array-index keys + hydration mismatch + localStorage versioning (61 warnings)

1 participant