fix(design): reduce design-system doctor warnings#335
Open
bntvllnt wants to merge 3 commits into
Open
Conversation
react-doctor \`design-no-space-on-flex-children\`: 13 → ~3. Rule rationale: per-sibling margins (space-x/y) phantom-gap on conditional render and don't mirror in RTL. Tailwind \`gap-x/y\` works on flex/grid parents and degrades correctly. Targeted line-by-line edit on the rule's flagged lines only — does not touch \`space-x/y\` outside flex/grid contexts. Files: - apps/registry/components/component-preview/component-preview.tsx (×7) - packages/ui/src/components/live-feed/live-feed.tsx (×1) - packages/ui/src/components/stat-card/stat-card.tsx (×1) - packages/ui/src/components/tutorial-complete/tutorial-complete.tsx (×1) Part of #267. Refs #279.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
bntvllnt
added
documentation
bntvllnt
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #267.
Related to #279.
Validation
pnpm -F @vllnt/ui exec eslint src/components/theme-toggle/theme-toggle.tsx src/components/social-fab/social-fab.tsx src/components/tutorial-mdx/tutorial-mdx.tsx src/components/tutorial-intro-content/tutorial-intro-content.tsx src/components/mdx-content/mdx-content.tsx src/components/thinking-block/thinking-block.tsx src/components/conversation-thread/conversation-thread.tsx src/components/spinner/spinner.tsxpnpm -F @vllnt/ui-registry exec eslint app/docs/page.tsx app/philosophy/page.tsx components/storybook-embed/storybook-embed.tsxpnpm -F @vllnt/ui lintpnpm -F @vllnt/ui exec tsc --noEmit --project tsconfig.build.jsonpnpm -F @vllnt/ui-registry exec tsc --noEmit --project tsconfig.jsonpnpm buildpnpm test:once(216 files, 1215 tests)pnpm -F @vllnt/ui check:use-clientpnpm -F @vllnt/ui exec tsx scripts/check-story-coverage.tspnpm -F @vllnt/ui exec tsx scripts/verify-stories.tspnpm -F @vllnt/ui build-storybookgit diff --checkgit diff --cached --checknpx --yes --silent react-doctor . --offline --json --json-compact ...design-rule query returned no findingsNotes
apps/registry/registry.jsonstill differs fromorigin/mainonly bygeneratedAttimestamp churn on this head.use clientwarnings and the existing animated-text MDX story export warning.CI status
39761b66dd4a79c416a6fa4ef0e27083f84f1617as of 2026-05-13 07:22 UTC: Quality Gates, Storybook Tests, Visual Regression, Build Storybook, Verify Stories, PR Issue Link, react-doctor, and Vercel previews.