Conversation
Signed-off-by: wuhuikx <Hattie.Wu@amd.com>
Signed-off-by: wuhuikx <Hattie.Wu@amd.com>
Signed-off-by: ganyi <ygan@amd.com>
Signed-off-by: ganyi <ygan@amd.com>
Signed-off-by: ganyi <ygan@amd.com>
Signed-off-by: zejunchen-zejun <zejun.chen@amd.com>
Signed-off-by: wuhuikx <Hattie.Wu@amd.com>
Signed-off-by: wuhuikx <Hattie.Wu@amd.com>
Signed-off-by: wuhuikx <Hattie.Wu@amd.com>
Signed-off-by: wuhuikx <hattie.wu@amd.com>
Signed-off-by: wuhuikx <hattie.wu@amd.com>
Signed-off-by: wuhuikx <Hattie.Wu@amd.com>
Signed-off-by: wuhuikx <Hattie.Wu@amd.com>
Signed-off-by: wuhuikx <Hattie.Wu@amd.com>
Update reference table with Radeon support indicators. Restructure MHA section: separate unified backends from ROCM_ATTN
Signed-off-by: wuhuikx <Hattie.Wu@amd.com>
Signed-off-by: wuhuikx <Hattie.Wu@amd.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2ea5acd5a9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| // Clean up and prepare for next iteration | ||
| if (isRunning) { | ||
| cleanupAnimationState(); |
There was a problem hiding this comment.
cleanupAnimationState() is asynchronous, but the loop restarts immediately without awaiting it, so on repeat cycles the next classifyRequests()/separateQKVBars() can run against a partially cleaned DOM (or a hidden combinedQKV), causing mispositioned bars and intermittent animation glitches after the first pass. This only appears when the auto-repeat path is exercised, but then it can break the core demo behavior.
Useful? React with 👍 / 👎.
Signed-off-by: Roy Wang <jasonailu87@gmail.com>
Signed-off-by: Roy Wang <jasonailu87@gmail.com>
Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: wuhuikx <hattie.wu@amd.com>
Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: wuhuikx <hattie.wu@amd.com>
Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: wuhuikx <hattie.wu@amd.com>
Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: wuhuikx <hattie.wu@amd.com>
Signed-off-by: wuhuikx <Hattie.Wu@amd.com>
Signed-off-by: wuhuikx <Hattie.Wu@amd.com>
Signed-off-by: wuhuikx <Hattie.Wu@amd.com>
Signed-off-by: wuhuikx <Hattie.Wu@amd.com>
…he animation Signed-off-by: wuhuikx <Hattie.Wu@amd.com>
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com> Signed-off-by: wuhuikx <Hattie.Wu@amd.com>
Signed-off-by: esmeetu <jasonailu87@gmail.com> Signed-off-by: wuhuikx <Hattie.Wu@amd.com>
Co-authored-by: Roy Wang <jasonailu87@gmail.com> Signed-off-by: wuhuikx <hattie.wu@amd.com> Signed-off-by: wuhuikx <Hattie.Wu@amd.com>
Signed-off-by: Roy Wang <jasonailu87@gmail.com>
Signed-off-by: Roy Wang <jasonailu87@gmail.com>
Signed-off-by: Roy Wang <jasonailu87@gmail.com>
Signed-off-by: esmeetu <jasonailu87@gmail.com>
Signed-off-by: esmeetu <jasonailu87@gmail.com>
Signed-off-by: esmeetu <jasonailu87@gmail.com>
6 participants
No description provided.