Skip to content

Conversation

@ylangtsou
Copy link
Collaborator

@ylangtsou ylangtsou commented Dec 4, 2025

Description

A new workflow to build and test vllm-tpu using the nightly tpu-inference package from PyPI, instead of building it from source and verify that the wheel builds and installs successfully, with vllm serve starting up correctly in an E2E environment. A 20-minute delay will be incorporated to allow sufficient time for the tpu-inference package to be published.

Tests

Pass on buildkite
Failed due to timeout on Buildkite

Checklist

Before submitting this PR, please make sure:

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.

@dennisYehCienet dennisYehCienet added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 4, 2025
@dennisYehCienet dennisYehCienet changed the title Verify vllm-tpu python package Verify vllm-tpu python package (draft) Dec 4, 2025
@ylangtsou ylangtsou requested a review from vipannalla as a code owner December 4, 2025 08:57
@dennisYehCienet dennisYehCienet marked this pull request as draft December 5, 2025 01:41
@ylangtsou ylangtsou force-pushed the ylangt/run_with_pypi branch from 3c1e18f to 87a31c2 Compare December 8, 2025 01:44
@CienetStingLin CienetStingLin added bug Something isn't working and removed bug Something isn't working labels Dec 8, 2025
@ylangtsou ylangtsou changed the title Verify vllm-tpu python package (draft) Add workflow to build vLLM-TPU wheel using PyPI tpu-inference Dec 11, 2025
@ylangtsou ylangtsou force-pushed the ylangt/run_with_pypi branch 2 times, most recently from 5967ddd to 981ba3b Compare December 12, 2025 03:33
@dennisYehCienet
Copy link
Collaborator

dennisYehCienet commented Dec 12, 2025

I think it's pretty good. Just a few things I want to mention.

It seems like you haven't included the main.yml procedure in your test.
Both steps depend on the record_verified_commit_hashes step, but your current Buildkite tests do not include it.
Please use main.yml to run a few test cases similar to our normal Buildkite procedure.

And, please provide two types of tests:
one that successfully pulls from PyPI and runs, and the other that fails after 20 minutes (due to timeout).
Please put these two test links into the PR description. You can then remove some of the testing code in the PR to make it formal.

Please update the PR description as well, as some information might be outdated. And we don't need to mention every file's changes, a brief summary of the PR is sufficient.

@ylangtsou ylangtsou force-pushed the ylangt/run_with_pypi branch 3 times, most recently from e2440ef to c53cb38 Compare December 18, 2025 07:35
@CienetStingLin CienetStingLin removed the request for review from vipannalla December 18, 2025 08:54
@CienetStingLin CienetStingLin marked this pull request as ready for review December 18, 2025 09:04
Signed-off-by: Ylang Tsou <ylangt@google.com>
@ylangtsou ylangtsou force-pushed the ylangt/run_with_pypi branch from c53cb38 to ba4dfeb Compare December 18, 2025 09:14
if: build.env("NIGHTLY") == "1"
depends_on: "record_verified_commit_hashes"
agents:
queue: tpu_v6e_queue
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can do the "add argument and enable v7" as well? not to be in the same PR but after merging and verify this.

buildkite-agent pipeline upload .buildkite/pipeline_jax_tpu7x.yml
# buildkite-agent pipeline upload .buildkite/pipeline_torch.yml
buildkite-agent pipeline upload .buildkite/main.yml
buildkite-agent pipeline upload .buildkite/nightly_releases.yml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a TODO:

instead of putting the "if nightly==1" inside the pipeline.yml. can we do the if check here and load "nightly" pipeline only when nightly==1?

Signed-off-by: Ylang Tsou <ylangt@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants