-
Notifications
You must be signed in to change notification settings - Fork 63
Add workflow to build vLLM-TPU wheel using PyPI tpu-inference #1241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
3c1e18f to
87a31c2
Compare
5967ddd to
981ba3b
Compare
|
I think it's pretty good. Just a few things I want to mention. It seems like you haven't included the And, please provide two types of tests: Please update the PR description as well, as some information might be outdated. And we don't need to mention every file's changes, a brief summary of the PR is sufficient. |
e2440ef to
c53cb38
Compare
Signed-off-by: Ylang Tsou <ylangt@google.com>
c53cb38 to
ba4dfeb
Compare
| if: build.env("NIGHTLY") == "1" | ||
| depends_on: "record_verified_commit_hashes" | ||
| agents: | ||
| queue: tpu_v6e_queue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can do the "add argument and enable v7" as well? not to be in the same PR but after merging and verify this.
| buildkite-agent pipeline upload .buildkite/pipeline_jax_tpu7x.yml | ||
| # buildkite-agent pipeline upload .buildkite/pipeline_torch.yml | ||
| buildkite-agent pipeline upload .buildkite/main.yml | ||
| buildkite-agent pipeline upload .buildkite/nightly_releases.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a TODO:
instead of putting the "if nightly==1" inside the pipeline.yml. can we do the if check here and load "nightly" pipeline only when nightly==1?
- @weiyu0824 for awareness, too.
Signed-off-by: Ylang Tsou <ylangt@google.com>
Description
A new workflow to build and test vllm-tpu using the nightly tpu-inference package from PyPI, instead of building it from source and verify that the wheel builds and installs successfully, with vllm serve starting up correctly in an E2E environment. A 20-minute delay will be incorporated to allow sufficient time for the tpu-inference package to be published.
Tests
Pass on buildkite
Failed due to timeout on Buildkite
Checklist
Before submitting this PR, please make sure: