Fix score payload typo and add regression test#769
Fix score payload typo and add regression test#769ruizhang0101 merged 4 commits intovllm-project:mainfrom
Conversation
keyuchen21
commented
Dec 16, 2025
- Correct the score model test payload to use text_2 instead of the misspelled test_2.
- Add a unit test to ensure the score payload contains the expected fields/values.
- Keeps /v1/score health checks and sample calls aligned with the helper.
Summary of ChangesHello @keyuchen21, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on improving the robustness and correctness of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request corrects a typo in the test payload for the score model type and adds a new unit test to prevent regressions. The changes are correct and address the issue. I've provided one suggestion to make the new test more comprehensive by verifying all fields in the payload, which will improve its robustness.
Signed-off-by: Keyu Chen <54015474+keyuchen21@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Keyu Chen <54015474+keyuchen21@users.noreply.github.com>
7a2ffef to
5ab7193
Compare
* Fix score payload typo and add regression test Signed-off-by: Keyu Chen <54015474+keyuchen21@users.noreply.github.com> * Update src/tests/test_utils.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Keyu Chen <54015474+keyuchen21@users.noreply.github.com> --------- Signed-off-by: Keyu Chen <54015474+keyuchen21@users.noreply.github.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Rui Zhang <51696593+zerofishnoodles@users.noreply.github.com>