Skip to content

fix fn signature help #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
spytheman merged 2 commits into from
Oct 24, 2025
Merged

fix fn signature help #469

spytheman merged 2 commits into from
Oct 24, 2025

Conversation

@kbkpbot
Copy link
Contributor

@kbkpbot kbkpbot commented Oct 23, 2025

  • modify -line-info "file.v:line:expr" to -line-info "file.v:line:col", as it will be difficult to analyze this expr when it contains extra : in it, e.g., -line-info "file.v:line:x:='a:b:c:d'.split(':')"
  • simplify fn signature logic, move fn signature logic to v

@kbkpbot kbkpbot closed this Oct 23, 2025
@kbkpbot kbkpbot reopened this Oct 23, 2025
@kbkpbot kbkpbot mentioned this pull request Oct 23, 2025
Merged
spytheman
spytheman approved these changes Oct 24, 2025
View reviewed changes
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman spytheman merged commit c2dfcdc into vlang:master Oct 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spytheman spytheman spytheman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kbkpbot @spytheman