tests: add fat closure acceptance targets#27466
Closed
MartenH wants to merge 1 commit into
Closed
Conversation
Author
|
After doing more research this is quite and undertaking and consider all the changes in memory management I decided to close at this tine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small draft/test-target PR for the fat-closure direction discussed around #27446/#27445.
It intentionally does not carry the frame-epoch reclamation runtime. Instead it adds opt-in acceptance tests for the desired representation boundary:
-d fat_closures, pure V stored closures should be GC-visible values and should not emitbuiltin.closuretrampoline creation/init code;Normal test runs pass because the checks are gated behind
fat_closures. To exercise the target today:v -d fat_closures -gc none test vlib/v/tests/fns/fat_closure_acceptance_test.vThat currently fails on the pure-V closure assertion, as intended: it is the executable acceptance target for a future fat-closure implementation.