fix(windows): guard titlebar_dark with sapp.isvalid()#60
Open
MartenH wants to merge 1 commit into
Open
Conversation
titlebar_dark() calls sapp.win32_get_hwnd(), which asserts _sapp.valid and aborts if sokol_app hasn't been initialised yet. set_theme() (and any early dark/light toggle) can run before sapp.run(), so on Windows the app aborts at startup before the window opens. Guard the DwmSetWindowAttribute call with sapp.isvalid() so an early call is a harmless no-op; once the window is up the attribute is applied exactly as before. Found bringing up vlang/gui on native Windows, but it's a real ordering bug independent of toolchain (reproduces under mingw-w64/gcc and MSVC).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while bringing up vlang/gui on native Windows, but it's a real ordering bug independent of toolchain (reproduces under both mingw-w64/gcc and MSVC).
titlebar_dark()callssapp.win32_get_hwnd(), which asserts_sapp.validand aborts if sokol_app hasn't been initialised yet:set_theme()(and any early dark/light toggle) can run beforesapp.run(), so on Windows the app aborts at startup before the window even opens.This guards the
DwmSetWindowAttributecall withsapp.isvalid(), so an early call is a harmless no-op; once the window is up the titlebar attribute is applied exactly as before.v fmt-clean. Verified on native Windows (mingw-w64 and MSVC builds both start cleanly with the guard).