windows: add native Windows support#59
Merged
Merged
Conversation
5a548d3 to
94151df
Compare
Contributor
|
Bouncing to force pickup of CI change. |
dy-tea
approved these changes
Jun 13, 2026
| medium f32 = -1 | ||
| large f32 = -1 | ||
| text f32 = -1 | ||
| spacing_small f32 = -1 @[json: 'small'] |
Contributor
Author
There was a problem hiding this comment.
This rename is internal only.
On the Windows/MSVC path, the generated C for SpacingBundle.small hit a name/macro collision and broke _theme_bundle_test.v. Renaming the V field avoids emitting small as the C member name.
The external theme JSON format is unchanged: @[json: 'small'] keeps the JSON key as "small", so theme bundles still use "spacing": { "small": ... }.
Member
There was a problem hiding this comment.
Ah right, I forgot that windows had small defined as a macro.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds native Windows support validation for
gui, centered on the MSVC/vcpkg path.This PR adds:
Validation
VJOBS=6 v test nativebridge/_readback_abi_test.v nativebridge/_bridge_ex_test.vVJOBS=6 v test _windows_setup_preflight_test.v winsetup/preflight_test.vv check-md README.md docs/WINDOWS.md docs/WINDOWS_MANUAL_SMOKE.md docs/PRINTING.md docs/ROADMAP.mdNotes
Some Windows behavior still requires real interactive/manual validation and is documented in
docs/WINDOWS_MANUAL_SMOKE.md, including native dialogs, notification delivery, PDF handler behavior and D3D11 runtime readback/export.