Error Handler, MD Shell: Console scrolling#40
Open
vladikcomper wants to merge 2 commits intomasterfrom
Open
Conversation
This only affects internally-used debug macros (external __FSTRING_* is unaffected). This is because all format symbols are underscored in this version.
- Extended Console state to include scrolling and VRAM/HSRAM/VSRAM data; - As a side effect, `Console.Clear` can be used in subdebuggers (e.g. backtrace, address registers); it was previously hardcoded to clear primary debugger's console only; - Major extension and refactoring of `ErrorHandler_PagesController` to support scrolling; - Init joypads in `ErrorHandler_ClearConsole`.
Owner
Author
|
This feature won't make it to MD Debugger 2.6, I'm changing target to 2.7. I have concerns including scrolling config into console config (as a simple output device, it should be dumber), need to think of a better approach. Auto-scrolling also only works with ErrorHandler_PagesController, which is far from ideal and it 4-directional scrolling feels a bit odd. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements basic console scrolling when pressing D-Pad. This should be extremely useful if screen content doesn't fit vertically (e.g. backtrace is too long).
TODO
Console.SetXYScrollmacro;Console.VSyncmacro (maybe squeeze it in here?);Console.Run;