Conversation
…g the build issues
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
checkstyle
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
'if' construct must use '{}'s.
'if' construct must use '{}'s.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
'if' construct must use '{}'s.
'if' construct must use '{}'s.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
Line is longer than 100 characters (found 120).
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
Line is longer than 100 characters (found 107).
tag should be placed immediately before the first word, with no space after.
Line is longer than 100 characters (found 101).
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
tag should be placed immediately before the first word, with no space after.
| * in VitruvOCL. | ||
| * | ||
| * <p>Unlike {@code oclIsKindOf}, {@code oclIsTypeOf} checks for exact type match (no subtype | ||
| * <p> |
There was a problem hiding this comment.
tag should be placed immediately before the first word, with no space after.
| Path.of("src/test/resources/test-metamodels/spaceMission.ecore"); | ||
| private static final Path SATELLITE_ECORE = | ||
| Path.of("src/test/resources/test-metamodels/satelliteSystem.ecore"); | ||
| private static final Path SPACEMISSION_ECORE = Path.of("src/test/resources/test-metamodels/spaceMission.ecore"); |
There was a problem hiding this comment.
Line is longer than 100 characters (found 114).
| private static final Path SATELLITE_ECORE = | ||
| Path.of("src/test/resources/test-metamodels/satelliteSystem.ecore"); | ||
| private static final Path SPACEMISSION_ECORE = Path.of("src/test/resources/test-metamodels/spaceMission.ecore"); | ||
| private static final Path SATELLITE_ECORE = Path.of("src/test/resources/test-metamodels/satelliteSystem.ecore"); |
There was a problem hiding this comment.
Line is longer than 100 characters (found 114).
| private static final Path SPACECRAFT_ATLAS = Path.of("spacecraft-atlas.spacemission"); | ||
| private static final Path SATELLITE_VOYAGER = Path.of("satellite-voyager.satellitesystem"); | ||
|
|
||
| @BeforeAll |
There was a problem hiding this comment.
Missing a Javadoc comment.
|
|
||
| TypeCheckVisitor typeChecker = | ||
| new TypeCheckVisitor(symbolTable, dummySpec, errors, scopeAnnotator); | ||
| TypeCheckVisitor typeChecker = new TypeCheckVisitor(symbolTable, dummySpec, errors, scopeAnnotator); |
There was a problem hiding this comment.
Line is longer than 100 characters (found 104).
| * Evaluates an if-then-else expression. | ||
| * | ||
| * <p>Evaluates the condition and returns the then-branch if true, else-branch if false. | ||
| * <p> |
There was a problem hiding this comment.
tag should be placed immediately before the first word, with no space after.
| * Implements short-circuit evaluation (only one branch is evaluated). | ||
| * | ||
| * <p><b>Syntax:</b> {@code if <condition> then <thenBranch> else <elseBranch> endif} | ||
| * <p> |
There was a problem hiding this comment.
tag should be placed immediately before the first word, with no space after.
| * {@code if <condition> then <thenBranch> else <elseBranch> endif} | ||
| * | ||
| * <p><b>Example:</b> {@code if age >= 18 then 'adult' else 'minor' endif} | ||
| * <p> |
There was a problem hiding this comment.
tag should be placed immediately before the first word, with no space after.
| * Evaluates an invariant constraint. | ||
| * | ||
| * <p>Processes all specification expressions in the invariant and returns the result of the last | ||
| * <p> |
There was a problem hiding this comment.
tag should be placed immediately before the first word, with no space after.
| * Evaluates the {@code isEmpty()} operation. | ||
| * | ||
| * <p>Returns true if the receiver collection contains zero elements. | ||
| * <p> |
There was a problem hiding this comment.
tag should be placed immediately before the first word, with no space after.
|
also changed the min() max() so that they work for Real types as well as Integer types. |
2 participants
No description provided.