feat(experimental): add print and fail thresholds #9533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s for importDurations
- Add `print: 'on-warn'` option to only show import breakdown when imports exceed warn threshold
- Add `thresholds: { warn, danger }` options to configure duration thresholds (default: 100ms, 500ms)
- Update reporter to use configurable thresholds instead of hardcoded values
- Update UI to read thresholds from config
Part of vitest-dev#9141
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
hi-ogawa
changed the title
print: 'on-warn' and importDurtaions.thresholds- Add `failOnDanger: boolean` option to fail the test run when imports exceed danger threshold - When failing, breakdown is always printed regardless of `print` setting - Sets `process.exitCode = 1` following the same pattern as coverage thresholds Part of vitest-dev#9141 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #9141
I was exploring a good option style and here I chose
print: boolean | "on-warn", which is somewhat inspired by Playwright (e.g. then haveuse: { trace: 'on-first-retry', screenshot: 'only-on-failure' }).Not sure if we can unify
failOnDanger: booleanthough. Still exploring.Summary
print: 'on-warn'option to only show import breakdown when imports exceed warn thresholdthresholds: { warn, danger }options to configure duration thresholds (default: 100ms, 500ms)Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.