Skip to content

chore: address sonarlint issues #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xaevik merged 1 commit into from
May 23, 2026
Merged

chore: address sonarlint issues #248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,7 @@ resharper_convert_to_primary_constructor_highlighting = none

# Meziantou Rules
dotnet_diagnostic.MA0003.severity = none
dotnet_diagnostic.MA0038.severity = none

#### Razor Files ####

Expand Down
2 changes: 1 addition & 1 deletion ...dressValidation.Integration.Google/Serialization/Json/ApiResponseJsonSerializerContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ namespace Visus.AddressValidation.Integration.Google.Serialization.Json;
[JsonSerializable(typeof(ApiErrorResponse))]
[JsonSerializable(typeof(ApiResponse))]
[JsonSourceGenerationOptions(WriteIndented = false, PropertyNamingPolicy = JsonKnownNamingPolicy.CamelCase)]
internal partial class ApiResponseJsonSerializerContext : JsonSerializerContext;
internal sealed partial class ApiResponseJsonSerializerContext : JsonSerializerContext;
2 changes: 1 addition & 1 deletion src/Visus.AddressValidation/Services/AbstractAuthenticationService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@
cancellationToken)
.ConfigureAwait(false);

if ( !factoryRan )
if ( !factoryRan ) // NOSONAR S2583 - false positive: factoryRan is mutated inside the async lambda above

Check warning on line 102 in src/Visus.AddressValidation/Services/AbstractAuthenticationService.cs

View workflow job for this annotation

GitHub Actions / Test & Analysis 

Change this condition so that it does not always evaluate to 'False'. Some code paths are unreachable.

Check warning on line 102 in src/Visus.AddressValidation/Services/AbstractAuthenticationService.cs

View workflow job for this annotation

GitHub Actions / Test & Analysis 

Change this condition so that it does not always evaluate to 'False'. Some code paths are unreachable.
{
return string.IsNullOrWhiteSpace(tokenResponse?.AccessToken) ? null : tokenResponse.AccessToken;
}
Expand Down
Loading