Fix crash in Trellis2ImageTo3DPipeline when progress_bar is None#155
Open
tmralmeida wants to merge 1 commit into
Open
Fix crash in Trellis2ImageTo3DPipeline when progress_bar is None#155tmralmeida wants to merge 1 commit into
tmralmeida wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug in the Trellis2ImageTo3DPipeline class where the pipeline crashes during execution if a progress bar is not provided.
Details
The Issue: In the _run() method, the progress_bar can evaluate to None. Currently, the code attempts to call .update() in here without checking its existence, which results in an AttributeError.
The Fix: Added a None check before updating the progress bar to safely handle executions where the progress bar is omitted.