fix(core): destroy CanvasContext on finalize to prevent memory leak#10356
Open
LeLunZ wants to merge 2 commits into
Open
fix(core): destroy CanvasContext on finalize to prevent memory leak#10356LeLunZ wants to merge 2 commits into
LeLunZ wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10355
Background
When unmounting a
Deckinstance (both standalone and via wrappers likeMapboxOverlay), a memory leak occurs where detached DOM nodes (the<canvas>) andDeckinstances are never garbage collected.Previously,
Deck.finalize()simply dropped the reference tothis._canvasContext. Becausethis._canvasContext?.destroy()was never explicitly called,luma.gl'sSurfacesuperclass never ran_stopObservers(). As a result, theResizeObserverandmatchMedialisteners remained permanently bound to the Window, creating a strong GC root that kept the detached canvas andDeckinstance alive indefinitely.Note: This was originally observed using
MapboxOverlay.Change List