Skip to content

[codex] Improve GlobeView bitmap tile effect handling#10353

Closed
charlieforward9 wants to merge 1 commit into
visgl:codex/bitmap-layer-lightingfrom
NEW-HEAT:codex/globe-bitmap-effect-handling
Closed

[codex] Improve GlobeView bitmap tile effect handling#10353
charlieforward9 wants to merge 1 commit into
visgl:codex/bitmap-layer-lightingfrom
NEW-HEAT:codex/globe-bitmap-effect-handling

Conversation

@charlieforward9

Copy link
Copy Markdown
Collaborator

Summary

This improves TileLayer's GlobeView handling for bitmap tile sublayers so image-coordinate setup stays compatible with deck.gl effects after BitmapLayer gains lighting/material support.

TileLayer now detects BitmapLayer sublayers rendered in GlobeView and, when their _imageCoordinateSystem is still default, clones them with _imageCoordinateSystem: COORDINATE_SYSTEM.CARTESIAN. This preserves explicit user-provided coordinate systems, including COORDINATE_SYSTEM.LNGLAT.

Why

XYZ/slippy tile imagery is Web Mercator encoded. In GlobeView, BitmapLayer positions the tile mesh in lng/lat, so tile imagery needs Mercator-to-lnglat UV conversion for the bitmap surface to line up correctly. That becomes more visible once lighting/effects are applied to BitmapLayer-backed tile imagery.

Dependency

This draft PR is stacked on and merge-blocked by #10352. Please do not merge this until #10352 lands, because the effect behavior depends on BitmapLayer lighting/material support from that PR.

Validation

  • npx vitest run --project headless test/modules/geo-layers/tile-layer/tile-layer.spec.ts
  • git diff --check
  • Attempted npx eslint modules/geo-layers/src/tile-layer/tile-layer.ts test/modules/geo-layers/tile-layer/tile-layer.spec.ts, but the local checkout's deck.gl ESLint 8.57.0 process loaded the parent workspace's ESLint 9-era @typescript-eslint/no-unused-expressions rule and failed before linting these changes: Cannot read properties of undefined (reading 'allowShortCircuit').

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 83.42% (+0.03%) from 83.39% — NEW-HEAT:codex/globe-bitmap-effect-handling into visgl:master

@charlieforward9 charlieforward9 changed the base branch from master to codex/bitmap-layer-lighting June 8, 2026 00:29
@charlieforward9

Copy link
Copy Markdown
Collaborator Author

Closing this draft. I do not want to pursue the TileLayer/GlobeView bitmap-coordinate path as a separate PR; the active work should stay consolidated in #10352 and shift toward TerrainLayer plus other mesh/model-related layers instead of a fully 2D layer path.

@charlieforward9 charlieforward9 deleted the codex/globe-bitmap-effect-handling branch June 8, 2026 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants