Skip to content

[codex] Add BitmapLayer lighting support#10351

Closed
charlieforward9 wants to merge 1 commit into
visgl:masterfrom
NEW-HEAT:codex/bitmap-layer-lighting
Closed

[codex] Add BitmapLayer lighting support#10351
charlieforward9 wants to merge 1 commit into
visgl:masterfrom
NEW-HEAT:codex/bitmap-layer-lighting

Conversation

@charlieforward9

Copy link
Copy Markdown
Collaborator

Summary

  • add BitmapLayer material prop support and register the Phong lighting shader module
  • pass camera/common-space position into the fragment shader and shade the sampled bitmap color with lighting_getLightColor
  • update BitmapLayer render goldens and add a shader-module regression assertion

Root Cause

BitmapLayer sampled and tinted texture color directly in its fragment shader, but it did not expose a material prop, include a lighting material shader module, or provide a normal/position path into lighting_getLightColor. Lighting effects such as _SunLight therefore had no shader path that could affect bitmap draws.

Validation

  • yarn vitest run --project headless test/modules/layers/bitmap-layer.spec.ts
  • yarn vitest run --project render test/render/test-cases/core-layers.spec.ts -t "bitmap-layer"
  • yarn lint (passes with existing repository warnings)

@charlieforward9

Copy link
Copy Markdown
Collaborator Author

Closing in favor of upstream-backed PR #10352 to avoid cross-repository branch issues.

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 83.386% (-0.004%) from 83.39% — NEW-HEAT:codex/bitmap-layer-lighting into visgl:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants