[codex] Add BitmapLayer lighting support#10351
Closed
charlieforward9 wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
Closing in favor of upstream-backed PR #10352 to avoid cross-repository branch issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lighting_getLightColorRoot Cause
BitmapLayer sampled and tinted texture color directly in its fragment shader, but it did not expose a material prop, include a lighting material shader module, or provide a normal/position path into
lighting_getLightColor. Lighting effects such as_SunLighttherefore had no shader path that could affect bitmap draws.Validation
yarn vitest run --project headless test/modules/layers/bitmap-layer.spec.tsyarn vitest run --project render test/render/test-cases/core-layers.spec.ts -t "bitmap-layer"yarn lint(passes with existing repository warnings)