Skip to content

NSDK-293 fix request #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ObranS wants to merge 1 commit into
base: trunk
Choose a base branch
from
+8 −3
Open

NSDK-293 fix request #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion virtusize/src/main/java/com/virtusize/android/compose/ui/VirtusizeComposeViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,10 @@ internal class VirtusizeComposeViewModel : ViewModel() {
fun load(
product: VirtusizeProduct,
virtusizeView: VirtusizeView,
force: Boolean = false,
) {
virtusize.setupVirtusizeView(product = product, virtusizeView = virtusizeView)
if (lastLoadedProductId != product.externalId) {
if (force || lastLoadedProductId != product.externalId) {
lastLoadedProductId = product.externalId
virtusize.load(product)
}
Expand Down
8 changes: 6 additions & 2 deletions virtusize/src/main/java/com/virtusize/android/compose/ui/VirtusizeInpPageStandard.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,12 @@ fun VirtusizeInPageStandard(

VirtusizeInPageStandard(
modifier = modifier,
create = { virtusizeInPageStandard ->
viewModel.load(product = product, virtusizeView = virtusizeInPageStandard, force = true)
},
update = { virtusizeInPageStandard ->
viewRef.value = virtusizeInPageStandard
viewModel.load(product = product, virtusizeView = virtusizeInPageStandard)
viewModel.load(product = product, virtusizeView = virtusizeInPageStandard, force = false)
},
)

Expand All @@ -73,6 +76,7 @@ fun VirtusizeInPageStandard(
@Composable
private fun VirtusizeInPageStandard(
modifier: Modifier = Modifier,
create: (VirtusizeInPageStandard) -> Unit = {},
update: (VirtusizeInPageStandard) -> Unit = NoOpUpdate,
) {
AndroidView(
Expand All @@ -81,7 +85,7 @@ private fun VirtusizeInPageStandard(
VirtusizeInPageStandard(context).apply {
horizontalMargin = 0
clipChildren = false
}
}.also { create(it) }
},
update = update,
onRelease = { virtusizeView ->
Expand Down