This repository was archived by the owner on Mar 28, 2026. It is now read-only.
[tidy] convert tabs to spaces#38
Closed
xtofl wants to merge 58 commits intovirtualmarc:masterfrom
Closed
Conversation
TODO: Gitlab API Returns 403 forbidden on register
- Force output by Default Encoding - Reject Executing path is begin with UNC path - There is no need to convert to UTF8 after Uri.EscapeDataString - Fix commands 'ls -la' will execute 'ls' and 'la' issue, and now, it will split by '\n' TODO: if commands contains '\\\n' it may occur an error, so it need to replace by ' ', and needs to confirm
Fix for reading process' stderr
Fix minor issues
use pre-generated id_rsa.pub if exist
chagen UAC level for running under msys is Admin really required?
change UAC level
…ated-ssh-key use pre-generated ssh key --- Edit after merge to check for id_rsa insead of id_rsa.pub
Checking for both: Public & Private Key, because we need to send the public Key to Gitlab and need the privat Key later to connect to the Git Server
complete BuildInfo get build command timeout from ci
…meout-from-ci get build command timeout from ci
imporve testcase use ci setting for clone or fetch
…ng-for-clone-fetch Feature/using ci setting for clone fetch
… timeout parameter and trim commands' CR and LF characters - set timeout=1800(GitLab CI default value) when JSON doesn't have timeout parameter, because old version of GitLab CI doesn't have timeout parameter in JSON response, so it will return null to info.timeout by fill 0, that occurred any command terminate immediately.
fix compatibility with old version of GitLab CI which doesn't support timeout parameter and trim commands' CR and LF characters
- using split by line to prevent this problem - replace source code from tab to space
- fix by using ToList clone a List to avoid exception was occurred by another thread changed __output
Prevent and fix 2 Exceptions
Junction points handling when recursively removing directories. Fixes virtualmarc#15
Fixed commands parsing - don't treat pipe (|) character as a new line separator
It is very bad idea to concatenate strings via '+'. Worst places are refactored. ThreadSafe output Some other trifles.
Some string usage refactoring.
Added Microsoft Long Path support for directory deletes
What caught my eye was `mysysgit`, otherwise the rest is really a question of style.
Minor formatting and spelling changes.
… GitLabCI v1 API)
Refactoring using ServiceStack.Client + SSL bypassing for self-signed certificate
…er should be enclosed in double quotes
Double quotes added to ssh-keygen directory parameter
Removed string escape of trace to make the output at GitLab CI more presentable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.