Estrazione libreria per uso standalone#84
Open
lmartorella wants to merge 2 commits intovirtualdj:masterfrom
Open
Estrazione libreria per uso standalone#84lmartorella wants to merge 2 commits intovirtualdj:masterfrom
lmartorella wants to merge 2 commits intovirtualdj:masterfrom
Conversation
- Moved implementation of _async_update_data in separate class - Added CLI standalone test to get hourly data only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salve,
Visto il buon livello raggiunto nel codice di estrazione di dati dal sito del GSE, ho pensato che potesse essere utile usare questa parte di libreria (solo data extract quindi) per l'integrazione in altri sistemi che non siano basati su HomeAssistant.
Come inizio ho provato a isolare meglio la classe
DataDownloader, e per provare a vedere se funziona bene in isolamento ho aggiunto un programma di test CLI in/test.Non posso putroppo però provare che il refactoring funzioni bene anche nel contesto originale HomeAssistant, per mancanza di test e2e.
Grazie!
L