Refactors VCell Object Cloning and Enhances Libvcell Data Access#1650
Merged
Refactors VCell Object Cloning and Enhances Libvcell Data Access#1650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update introduces a comprehensive refactoring of object cloning mechanisms within VCell, moving away from generic Java serialization for a more explicit and controlled deep cloning approach.
Key changes include:
deepClone()methods for various core objects, including BioNetGen (BNG) specification elements (e.g., BNGMolecule, BNGOutputSpec), geometry surface components (e.g., OrigSurface, Polygons), and math objects (e.g., JumpCondition, AnnotatedFunction).XmlHelper, allowing for more robust and controlled replication.XmlHelperto utilize XML-based cloning primarily forlibvcellcontexts, providing a more reliable cloning mechanism for external integrations.DataSetclass to make its constructor and key methods (read(),getVariableTypeInteger()) public, facilitating direct access and manipulation of field data fromlibvcell.INCONSISTENT_UNIT_SYSTEMto catch incompatibilities in substance units, improving overall model consistency.This refactoring aims to improve the stability, performance, and maintainability of object cloning, particularly benefiting integration efforts with
libvcell.