fix: Pin onboarding modal navigation buttons for 13-inch displays#32
Open
kushvinth wants to merge 1 commit intovirtualcell:mainfrom
Open
fix: Pin onboarding modal navigation buttons for 13-inch displays#32kushvinth wants to merge 1 commit intovirtualcell:mainfrom
kushvinth wants to merge 1 commit intovirtualcell:mainfrom
Conversation
Author
|
PTAL @KacemMathlouthi @Ezequiel-Valencia and @vcellmike, ones this gets through as explained my mike on nrnb/GoogleSummerOfCode#282 (comment) i will start working on more core features like the UV CI/CD which i proposed here #30 |
This was referenced Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On 13-inch devices (viewport height ~900px), the onboarding modal's Previous/Next navigation buttons were not visible on the first two steps (Natural Language Queries & Available Tools). Users had to scroll the entire modal to find the buttons, which made the onboarding experience confusing many users wouldn't even realise the buttons existed.
Problem
The
DialogContentcontainer hadoverflow-y-autoapplied to the entire modal, meaning the header, content, and footer (navigation buttons) all scrolled together as one block. On smaller screens wheremax-h-[70vh](~630px on a 13-inch display) wasn't tall enough to fit all the content, the Previous/Next buttons were pushed below the visible area.Steps to reproduce:
/chatSolution
Restructured the modal layout from a single scrollable container to a flex column layout with three distinct sections:
flex-shrink-0flex-1 min-h-0 overflow-y-autoflex-shrink-0Testing
Tested on 1440×900 viewport (13-inch MacBook simulation). Previous and Next buttons are visible on all 4 steps without scrolling. Content area scrolls independently when needed and No visual regression on larger displays
Before
CleanShot.2026-03-05.at.00.49.16.mp4
CleanShot.2026-03-05.at.00.54.44.mp4
After
CleanShot.2026-03-05.at.00.48.29.mp4
CleanShot.2026-03-05.at.00.59.37.mp4
Related Issues