complete specs for stock movement model#137
Open
sawangupta92 wants to merge 4 commits into
Open
Conversation
sawangupta92
commented
Feb 29, 2016
sawangupta92
commented
- Use constant QUANTITY_LIMITS for maximum and minimum quantity.
- Use persisted? instead of !new_record? in #readonly?.
- Write rspecs for Constants, Associations, Validations, Callbacks, Ransackable attributes, Scope, #readonly?
- Move #update_stock_item_quantity to describe block of Instance Methods
1) use is_expected syntax for should a matcher 2) change quantity contstants to a single hash
| QUANTITY = { | ||
| max: 2147483647, | ||
| min: -2147483648 | ||
| } |
There was a problem hiding this comment.
Please use 2*31 instead of exact number. Rename it to QUANTITY_LIMITS
|
@sawangupta92 please add proper description to this PR. |
|
@sawangupta92 It looks good to me. Please raise on Spree with same description in PR |
sawangupta92
force-pushed
the
spec-for-stock-movement
branch
from
b0f7b9d to
45652ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.