Skip to content

Library refresh#19

Open
slavikdenis wants to merge 7 commits intovineyardbovines:masterfrom
slavikdenis:master
Open

Library refresh#19
slavikdenis wants to merge 7 commits intovineyardbovines:masterfrom
slavikdenis:master

Conversation

@slavikdenis
Copy link
Copy Markdown

Hi :)

I've fixed some problems I've faced while using this library:

  • resolving promises in the native module on early returns (if you are awaiting them, they are endless)
  • preventing crashes on other platforms (if using the hook, iOS fails of course --> return false on other platforms for the methods)
  • replace !! operator with ? safe call operator (see Kotlin docs - Null safety)

While working on these changes, I updated some other things that I came across:

  • updating .gitignore (after opening the project, a bunch of new files popped up, updated accordingly to https://github.com/github/gitignore/blob/main/Android.gitignore)
  • updating README (fixing yarn install, mentioning minSdkVersion [preventing issues like Compilation error about minSdkVersion #11 ], adding a warning about other platforms)
  • fixing development scripts (running yarn lint on the pre-commit hook for .js,.ts files, adding missing yarn lint:ts which was included in the pre-commit hook already, running yarn lint:ts only for .ts files
  • correcting tsconfig.json to skip library check (failing on some node_module declaration files, if false)

Thank you for your time and let me know if any changes are needed.

@slavikdenis
Copy link
Copy Markdown
Author

Hi @Gretzky :) Do you think you could take a look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant