fix: remove session compression to improve performance#39
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
==========================================
- Coverage 82.09% 81.77% -0.33%
==========================================
Files 26 26
Lines 1793 1761 -32
Branches 178 176 -2
==========================================
- Hits 1472 1440 -32
Misses 318 318
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lambdalisue
force-pushed
the
fix-session-performance
branch
from
179c579 to
ebfc896
Compare
Session saving/loading was using brotli compression which added unnecessary overhead. Sessions are now stored uncompressed in memory for better performance. Changes: - Remove brotli compression dependency - Make savePickerSession and loadPickerSession synchronous - Update all dependent files to handle uncompressed sessions - Update documentation to reflect the change 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
lambdalisue
force-pushed
the
fix-session-performance
branch
from
ebfc896 to
f55583b
Compare
lambdalisue
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
savePickerSessionandloadPickerSessionsynchronous functionsBackground
Session compression was causing performance issues when saving picker sessions. By removing the compression overhead, sessions are now saved and loaded much faster.
Changes
brotlicompression dependency fromsession.tsPickerSessionCompressedtype and related compression/decompression functionssavePickerSessionto be synchronous (no longer returns a Promise)loadPickerSessionto be synchronous (no longer returns a Promise)doc/fall.txtto remove mention of compressionTest plan
🤖 Generated with Claude Code