Alternative solution to #316: add requestModules capability#498
Open
vaughan99 wants to merge 1 commit intovilladora:masterfrom
Open
Alternative solution to #316: add requestModules capability#498vaughan99 wants to merge 1 commit intovilladora:masterfrom
vaughan99 wants to merge 1 commit intovilladora:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also need the ability to follow redirects automatically, but I realize the original #316 solution was intrusive in that it forced everyone to use
follow-redirects. With a little more work, I wanted to present this solution, which instead allows for a dependency injection of request modules into the proxy. This alleviatesexpress-http-proxyof any responsibility to supportfollow-redirectsdirectly, and allows for custom request modules as well.