Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #366 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 336 336
Branches 26 26
=========================================
Hits 336 336 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I am quite skeptic about replacing all of these tools by ruff. My understanding is that not all of the lints available in pylint, flake8 etc. are already available in ruff. All of these tools and black are the golden standard. For example if black and ruff would format the code differently, I would accept the black version. What is your opinion about that? |
|
Please read the ruff docs. All of those old wives' tales are explained there. Black and flake8 are where the puck has gone in the past. Ruff is where the puck is and where it is going in the future. |
Could you please be more specific? It seems that there are some pylint rules, which are not yet in ruff (cf. astral-sh/ruff#970). |
|
If you want to run both ruff and pylint, go for it. |
@cclauss: could you please update this PR or create a new one, which makes the necessary changes to |
|
Brought back pylint. |
Updated pylint dependency version from 4.0.1 to 4.0.2.
Once this pull request is merged, contributors can attempt to remove ignored Ruff rules to increase compliance.
black_formatis no longer needed because we lint and format Python code before we run pytest. No need to test code if it does not pass the basic sanity checks.python_test (ubuntu-24.04, 3.11)was renamed topython_test (ubuntu-24.04, 3.12)to give us a better chance of detecting problems.