Skip to content

Add SHA256 hashing example for issue #142Add SHA256 hashing example for issue #142Create sha256_usage.py#363

Open
mathurojus wants to merge 1 commit intovil02:masterfrom
mathurojus:mathurojus-patch-1
Open

Add SHA256 hashing example for issue #142Add SHA256 hashing example for issue #142Create sha256_usage.py#363
mathurojus wants to merge 1 commit intovil02:masterfrom
mathurojus:mathurojus-patch-1

Conversation

@mathurojus
Copy link
Copy Markdown

This example demonstrates the usage of create_puzzles with SHA256 hashing function and custom salt/spice values, addressing issue #142.

This example demonstrates the usage of create_puzzles with SHA256 hashing function and custom salt/spice values, addressing issue vil02#142.
Copy link
Copy Markdown
Owner

@vil02 vil02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mathurojus: thank for creating this PR! Few remarks:

  • the examples are required to use the same set of questions and answers. Otherwise the check_examples part will fail (cf. run_all_examples.sh),
  • the used hash defaults to sha512. Maybe it is worth mentioning that using shorter hashes like sha256 or md5 reduces the output size (it is just a puzzle, so one should not be to concerned with the security).

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (17d1043) to head (f4483dd).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #363   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          309       309           
  Branches        26        26           
=========================================
  Hits           309       309           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vil02
Copy link
Copy Markdown
Owner

vil02 commented Oct 3, 2025

@mathurojus : by the way: this repository has the hacktoebrfest tag, so this PR will count as your hacktoberfest contribution (as soon as it will be merged).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants