Change parseEnvKeys return type and warn on empty env keys#38
Merged
vidya381 merged 3 commits intovidya381:mainfrom Mar 9, 2026
Merged
Change parseEnvKeys return type and warn on empty env keys#38vidya381 merged 3 commits intovidya381:mainfrom
vidya381 merged 3 commits intovidya381:mainfrom
Conversation
Owner
|
loop returns on the first empty key so if multiple keys are empty only one gets reported. map iteration order is random so which one gets reported is non-deterministic. should collect all empty keys first then report them together. |
Contributor
Author
|
vidya381
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #14
summary:
map[string]struct{}tomap[string]string