Skip to content

Change parseEnvKeys return type and warn on empty env keys#38

Merged
vidya381 merged 3 commits intovidya381:mainfrom
abskptnyk:main
Mar 9, 2026
Merged

Change parseEnvKeys return type and warn on empty env keys#38
vidya381 merged 3 commits intovidya381:mainfrom
abskptnyk:main

Conversation

@abskptnyk
Copy link
Contributor

@abskptnyk abskptnyk commented Mar 8, 2026

fixes #14

summary:

  • changed parseEnvKeys return type from map[string]struct{} to map[string]string
  • added warning when key is present but value is empty

@vidya381
Copy link
Owner

vidya381 commented Mar 8, 2026

loop returns on the first empty key so if multiple keys are empty only one gets reported. map iteration order is random so which one gets reported is non-deterministic. should collect all empty keys first then report them together.

@abskptnyk abskptnyk reopened this Mar 9, 2026
@abskptnyk
Copy link
Contributor Author

  1. you're right about iterating over all keys
  2. faced some issues while rebasing, causing me to force-push, which consequently closed this PR

@vidya381 vidya381 merged commit 24a5893 into vidya381:main Mar 9, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warn when .env keys exist but values are empty

2 participants