fix: declare fscreen runtime dependency#1842
Merged
mihar-22 merged 1 commit intoJun 9, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fscreenfrom thevidstackpackage dev dependencies into runtime dependencies@types/fscreendev dependency for local TypeScript buildsfscreenwhen installingvidstackFixes #1841.
Why
packages/vidstack/src/foundation/fullscreen/controller.tsandpackages/vidstack/src/core/api/player-state.tsimportfscreen. The published server bundle can therefore resolvefscreenat runtime in SSR/test environments, but the package manifest only listed it as a dev dependency.Verification
corepack pnpm install --lockfile-onlycorepack pnpm install --frozen-lockfile --ignore-scriptsnode -e "const p=require('./packages/vidstack/package.json'); if(!p.dependencies.fscreen) throw new Error('fscreen missing from dependencies'); if(p.devDependencies.fscreen) throw new Error('fscreen still in devDependencies'); console.log('manifest ok', p.dependencies.fscreen)"corepack pnpm --filter vidstack typecheckcorepack pnpm --filter vidstack exec vitest --run src/foundation/fullscreen/controller.test.ts src/core/api/player-state.test.tsThe focused Vitest command matched and ran
src/core/api/player-state.test.tssuccessfully; there does not appear to be a matchingcontroller.test.tsfile in this checkout.