Skip to content

fix: declare fscreen runtime dependency#1842

Merged
mihar-22 merged 1 commit into
vidstack:mainfrom
xianzuyang9-blip:codex/declare-fscreen-runtime-dep
Jun 9, 2026
Merged

fix: declare fscreen runtime dependency#1842
mihar-22 merged 1 commit into
vidstack:mainfrom
xianzuyang9-blip:codex/declare-fscreen-runtime-dep

Conversation

@xianzuyang9-blip

Copy link
Copy Markdown
Contributor

Summary

  • move fscreen from the vidstack package dev dependencies into runtime dependencies
  • keep the existing @types/fscreen dev dependency for local TypeScript builds
  • refresh the pnpm lockfile so consumers receive fscreen when installing vidstack

Fixes #1841.

Why

packages/vidstack/src/foundation/fullscreen/controller.ts and packages/vidstack/src/core/api/player-state.ts import fscreen. The published server bundle can therefore resolve fscreen at runtime in SSR/test environments, but the package manifest only listed it as a dev dependency.

Verification

  • corepack pnpm install --lockfile-only
  • corepack pnpm install --frozen-lockfile --ignore-scripts
  • node -e "const p=require('./packages/vidstack/package.json'); if(!p.dependencies.fscreen) throw new Error('fscreen missing from dependencies'); if(p.devDependencies.fscreen) throw new Error('fscreen still in devDependencies'); console.log('manifest ok', p.dependencies.fscreen)"
  • corepack pnpm --filter vidstack typecheck
  • corepack pnpm --filter vidstack exec vitest --run src/foundation/fullscreen/controller.test.ts src/core/api/player-state.test.ts

The focused Vitest command matched and ran src/core/api/player-state.test.ts successfully; there does not appear to be a matching controller.test.ts file in this checkout.

@mihar-22 mihar-22 merged commit d2ece08 into vidstack:main Jun 9, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: fscreen is not declared as a dependency but is imported by the server bundle

2 participants