Update component.js

[sethborg]

Removed the html tag so firefox would not continue to download the movie file in the background.

[heff]

Thanks for helping out. Instead of component.js, this should go in the html5 tech's dispose method.
https://github.com/videojs/video.js/blob/v4.6.3/src/js/media/html5.js#L64

[sethborg]

OK what's the status now?

[heff]

Here's what I think needs to happen there:

vjs.Html5.disposeMediaElement(this.el_);
vjs.MediaTechController.prototype.dispose.call(this);

We should be referring the the tech's element here instead of the player's tag. They're one in the same except on platforms where we throw away the original tag and create a new element. When that happens we already dispose the original tag correctly, but without this change we'd miss disposing the newly created element.

Can you test if this does what you need it to?

[sethborg]

Tested. Yes that works.

[heff]

Great, thanks. Will merge in soon.
On July 10, 2014 at 12:42:06 PM, sethborg (notifications@github.com) wrote:

Tested. Yes that works.

—
Reply to this email directly or view it on GitHub.

[sethborg]

Disappointed to see 4.6.4 does not contain this fix.

[mmcc]

@sethborg Sorry about that, 4.6.4 had some pretty crucial fixes that needed to go out as soon as possible. Since we were releasing on a Friday afternoon we opted to keep it as simple as possible to avoid breaking things for everyone over a weekend :) This will get pulled in soon.

[heff]

Made some updates and waiting on @sethborg's approval: sethborg#1

[heff]

@sethborg Thanks for the help! This will go out with the next minor release.