fix: handle getter-only inBandMetadataTrackDispatchType on native tracks#1606
Open
xxiaoxiong wants to merge 1 commit into
Open
fix: handle getter-only inBandMetadataTrackDispatchType on native tracks#1606xxiaoxiong wants to merge 1 commit into
xxiaoxiong wants to merge 1 commit into
Conversation
On browsers with native text tracks (e.g. Firefox), addTextTrack returns a native TextTrack where inBandMetadataTrackDispatchType is a getter-only property. Setting it throws a TypeError. This wraps the assignment in a try-catch to gracefully handle environments where the property is read-only. Fixes videojs/video.js#8053
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using
nativeTextTrackson Firefox, callingtech.addTextTrack()returns a nativeTextTrackwhereinBandMetadataTrackDispatchTypeis a getter-only property. Attempting to set it throws:TypeError: setting getter-only property "inBandMetadataTrackDispatchType"This wraps the assignment in a try-catch to gracefully handle environments where the property is read-only.
Related Issues
Fixes videojs/video.js#8053
References