RSDK-13800: Fix _dial_app to pass dial options to _dial_direct#1211
Open
claude[bot] wants to merge 1 commit intomainfrom
Open
RSDK-13800: Fix _dial_app to pass dial options to _dial_direct#1211claude[bot] wants to merge 1 commit intomainfrom
claude[bot] wants to merge 1 commit intomainfrom
Conversation
_dial_app was ignoring dial options (like insecure=True), causing SSL errors when connecting to insecure localhost app instances. RSDK-13800 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_dial_appwas not accepting or forwardingDialOptionsto_dial_direct, so options likeinsecure=Truewere silently ignored when connecting to the app endpoint_dial_appto accept an optionalDialOptionsparameter and pass it throughViamClient.create_from_dial_optionsto pass itsdial_optionsto_dial_appTest plan
test_passes_dial_options_to_dial_app— verifies_dial_appis called with the dial options (includinginsecure=True) and default app URLtest_passes_dial_options_with_custom_url— verifies_dial_appis called with both a custom URL and dial options🤖 Generated with Claude Code