[RSDK-13658] Expose force_relay/force_p2p/turn_uri DialOptions#1208
Open
danielbotros wants to merge 4 commits intomainfrom
Open
[RSDK-13658] Expose force_relay/force_p2p/turn_uri DialOptions#1208danielbotros wants to merge 4 commits intomainfrom
danielbotros wants to merge 4 commits intomainfrom
Conversation
Add the matching Python kwargs for the rust-utils FFI flags landed in viamrobotics/rust-utils#176 so SDK callers can drive ICE relay/P2P testing and TURN-server filtering without reaching into the C ABI. Switches `_Runtime` to the `viam_*`-prefixed FFI symbols (viam_init_rust_runtime / viam_dial / viam_free_string / viam_free_rust_runtime). The previously called functions were already `#[deprecated]` upstream; this just stops asking for the deprecation warning and lets us pass the new args. Mirrors rust-utils' two pre-flight conflict warnings (force_relay + force_p2p, force_p2p + turn_uri) on the Python side so callers see them before the FFI hop. Compatibility: requires a rust-utils release that ships PR #176. Once that release is out, `etc/postinstall.sh` will pull a dylib whose viam_dial accepts the new 10-arg signature; older dylibs do not, and calling this code against them is undefined behavior. **Do not merge this PR until that rust-utils release is cut.** Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
stuqdog
approved these changes
May 5, 2026
Member
stuqdog
left a comment
stuqdog
left a comment
There was a problem hiding this comment.
lgtm! note though that this shouldn't be merged until the corresponding rust-utils feature is.
7 tasks
|
Hey @danielbotros — this PR has been approved and CI has been green for 3+ business days. Ready to merge? Auto-comment from overwatch. Will not re-nudge for 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
force_relay,force_p2p, andturn_urikwargs toDialOptionsso SDK callers can drive the ICE relay/P2P testing and TURN-server filtering knobs that rust-utils now exposes throughviam_dial._Runtimeto theviam_*-prefixed FFI symbols (viam_init_rust_runtime,viam_dial,viam_free_string,viam_free_rust_runtime). The previously called functions are already#[deprecated]upstream — this just stops asking for the deprecation warning and lets us pass the new args.Test plan
_Runtime()resolves all fourviam_*symbols and init/release runs cleanlyforce_relayactually pins to relay candidates against coturn server andforce_p2ppins to reflexive or local candidates using new rust-utils dylib.🤖 Generated with Claude Code