RSDK-13961: Default to static conan builds#635
Open
lia-viam wants to merge 1 commit into
Open
Conversation
seanavery
approved these changes
May 13, 2026
Member
There was a problem hiding this comment.
Thanks for the heads up!
Will try removing the explicit shared option setter after bumping the sdk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tagging reviews for some people who work on modules that consume viam-cpp-sdk, hopefully this should make your build code and readmes simpler!
This PR was claude-generated with the following prompt:
The same can probably be done in your own repos to simplify all the documentation and build script logic to set shared=False.