RSDK-13547- dh params from urdf#629
Conversation
…0417-RSDK-13547-DH-params
|
I think let's omit the latex/pdf, if you want to host it elsewhere maybe it could be in a doc comment or something Other than that my question is more, what is this doing and does it belong in viam-cpp-sdk? Without having a super good grasp of what's going on, this seems a little more domain specific than what we usually include here. I'm also wondering if we need to add a dependency on eigen or if we can't get away with using xtensor or some of the existing AxisAngles or Vector3 classes |
I feel comfortable removing the pdf. Can you please clarify if the tex file can stay?
What it does: Converts a URDF (one way of describing arm kinematics) into DH parameters (more compact representation). Why here: Planned extensions to trajex consume DH parameters, so we need a clean URDF to DH path to feed the module.
I can look into this. |
|
ok that makes sense. if we want to keep the tex file i think it probably belongs in the doc folder rather than the sdk tree directly |
I've added a
latexsubfolder which contains the.texfile and the.pdffile which guide the implementation of this code as well as explain the math.Here is a very good video (short and easy to understand) to gain intuition on what: a, d, \alpha, \theta are:
https://www.youtube.com/watch?v=rA9tm0gTln8
Should it be chosen to review the mathy code here, this is the order of functions I'd recommend:
I've also added plenty of comments to show how certain parts of the code tie into the underlying mathematical document