RSDK-13854: OpenTelemetry support#626
Open
lia-viam wants to merge 32 commits into
Open
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
lia-viam
requested review from
allisonschiang
and removed request for
a team and
allisonschiang
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…into opentel-prototype
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic support for OpenTelemetry in viam-cpp-sdk. This hooks opentel into client/server API boundaries, so that, eg, a
Sensor.GetReadingsrequest will generate a span in RDK with a subspan showing how much time was spent just in viam-cpp-sdk.The architecture is similar to the log backend and logging through RobotClient: there is an impl class that lives in the
Instance, some setup logic on startup, and a RobotClient method which sends RPCs to RDK.Config options should be documented in the build code, but basically this is off by default and effectively a conan exclusive, because system package managers have spotty support for opentel. Note that in addition to the compile-time build switch, there is also a runtime env var check