Skip to content

[RSDK-13658] Update viam_dial stub to match new 10-arg signature#624

Draft
danielbotros wants to merge 2 commits intomainfrom
update-viam_dial-stub-for-new-args
Draft

[RSDK-13658] Update viam_dial stub to match new 10-arg signature#624
danielbotros wants to merge 2 commits intomainfrom
update-viam_dial-stub-for-new-args

Conversation

@danielbotros
Copy link
Copy Markdown
Member

@danielbotros danielbotros commented May 5, 2026 •
edited
Loading

Summary

  • Extends the viam_dial stub in viam_rust_utils_stubs.cpp to match the new 10-arg signature added in rust-utils RSDK-13658 due to new dial options being added and updating the Python SDK to expose them.
  • The stub is only compiled on platforms without a real rust-utils build (currently non-x86_64 Windows). On every other platform the C++ SDK links the real rust-utils library and this file is excluded from the build, so this change has no effect there.
  • Won't merge until rust-utils tagged release with the new 10-arg viam_dial is published.

Test plan

  • Confirm rust-utils release containing the new viam_dial signature is published before merge.
  • Verify Windows-ARM CI (or a manual Windows-ARM build) compiles cleanly post-release.
  • No regression on macOS / Linux / Windows x86_64 (stub is excluded from those builds).

🤖 Generated with Claude Code

@danielbotros @claude
Update viam_dial stub to match new 10-arg signature
aad7ebe 
The rust-utils `viam_dial` FFI gained three new trailing parameters
(`c_force_relay`, `c_force_p2p`, `c_turn_uri`). The C++-side stub used
on platforms without a real rust-utils build (currently non-x86_64
Windows) must mirror the header signature; otherwise the next pickup
of the new rust-utils header would fail to compile on those platforms.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@danielbotros danielbotros requested a review from a team as a code owner May 5, 2026 17:53
@danielbotros danielbotros requested review from allisonschiang and njooma and removed request for a team May 5, 2026 17:53
@danielbotros danielbotros marked this pull request as draft May 5, 2026 17:59
@danielbotros danielbotros mentioned this pull request May 5, 2026
Open
7 tasks
@danielbotros danielbotros reopened this May 5, 2026
@danielbotros danielbotros changed the title Update viam_dial stub to match new 10-arg signature [RSDK-13658] Update viam_dial stub to match new 10-arg signature May 5, 2026
@danielbotros danielbotros requested a review from stuqdog May 5, 2026 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuqdog stuqdog stuqdog approved these changes

@njooma njooma Awaiting requested review from njooma njooma is a code owner automatically assigned from viamrobotics/sdk-netcode

@allisonschiang allisonschiang Awaiting requested review from allisonschiang allisonschiang is a code owner automatically assigned from viamrobotics/sdk-netcode

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danielbotros @stuqdog