RSDK-13852 - fix mdns connection failures#177
Open
stuqdog wants to merge 2 commits intoviamrobotics:mainfrom
Open
RSDK-13852 - fix mdns connection failures#177stuqdog wants to merge 2 commits intoviamrobotics:mainfrom
stuqdog wants to merge 2 commits intoviamrobotics:mainfrom
Conversation
stuqdog
commented
May 4, 2026
Comment on lines
+66
to
+69
| # Override viam-mdns with the local development version while the macOS fix is | ||
| # not yet published. Remove this section before releasing a new crate version. | ||
| [patch.crates-io] | ||
| viam-mdns = { path = "../mdns" } |
Member
Author
There was a problem hiding this comment.
This will be removed before merging.
Member
Author
|
@viamrobotics/netcode adding you all here because this work is veering into netcode-y territory. Happy to chat with y'all about it! Also note that stuqdog/mdns#2 is a necessary precursor here. |
Member
|
seems fine to me, @danielbotros will probably have the most context |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-written with claude code.
Note that this is blocked on stuqdog/mdns#2 being released, test failures until that time are expected.
Changes:
Testing: