Sync upstream#28
Merged
Merged
Conversation
Previous logic had some issues: * `CMAKE_PREFIX_PATH` may be a list of paths * `CMAKE_INSTALL_PREFIX` can be different from WFA2-lib path find_path will search every path in `CMAKE_PREFIX_PATH` along with some other locations like `CMAKE_INCLUDE_PATH` and `CMAKE_INSTALL_PREFIX`. Also user can override detection using variables.
Rework CMake config to use targets
Use find_path to set WFA_INCLUDE_DIRS
Enable shared libraries via `-DBUILD_SHARED_LIBS=ON`
Install WFBINS, use standard mandir, add tabix.hpp if needed
…duplication Removed loadIndices duplication
change old style for loop with range based. Also fixed const correctness in a few places.
This reverts commit a6bbda0.
This should fix vcflib#448
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings us up to date with upstream vcflib and adds the patches we need to still build
libvcflib.aon Mac.