chore(deps): bump fork to v0.5.1; drop Error→exited workaround (bd openlock-z9i, openlock-jqj)#42
Merged
Conversation
Fork v0.5.1 adds SandboxPhase::Stopped (vessux/OpenShell#5), so `openshell sandbox stop` now transitions Ready → Stopped instead of Ready → Error. Drop the Error → "exited" hack added against v0.5.0; genuine Error phases now correctly surface as "other" rather than masquerading as an intentional stop. bd close openlock-z9i openlock-jqj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OPENSHELL_FORK_TAGfrom v0.5.0 → v0.5.1 (feat(sandbox): SandboxPhase::Stopped distinguishes intentional stop from crash OpenShell#5 —SandboxPhase::Stopped).Error → "exited"fallback inparseSandboxGetPhase. Stops now reportStopped; genuineErrorphases correctly surface as"other".Test plan
bun run lint && bun run typecheck && bun run test && bun run knipcleanopenlock sandbox→ exit harness →openshell sandbox getshowsPhase: Stopped→ reattach starts cleanly without manualgateway startlimactl shell openshell-linux