chore(ci): drop inherited NVIDIA mirror plumbing#4
Merged
Conversation
required-ci-gates.yml posts five "Waiting for /ok to test mirror" pending statuses on every PR (Branch Checks, Helm Lint, Branch E2E Checks, GPU Test, Branch Kubernetes E2E). These never resolve on this fork because two pieces of upstream infrastructure are missing: - No `/ok to test <SHA>` issue-comment handler exists in our .github/workflows/. Upstream runs it as an external GitHub App that we cannot import. - No fork-side self-hosted runners are registered, so the worker workflows (branch-checks.yml, helm-lint.yml, branch-e2e.yml, test-gpu.yml, branch-kubernetes-e2e.yml) cannot execute even when manually dispatched: they target `linux-amd64-cpu8` / `linux-arm64-cpu8` and a private `ghcr.io/nvidia/openshell/ci` container image. e2e-label-help.yml is the partner workflow that posts a hint comment when a `test:e2e*` label is applied. Without the `/ok` handler the hint points at a command that does nothing on this fork. Delete both. The worker workflows stay in place: they are inert (unrunnable for the reasons above) and removing them would create a larger surface to merge back when upstream changes. Effect: PRs no longer show two perpetually-yellow checks. The fork's real CI signal (CodeQL, openlock-release, ci-image, etc.) is unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Delete `required-ci-gates.yml` + `e2e-label-help.yml` — the two workflows that post the perpetual "Waiting for /ok to test mirror" pending statuses on every fork PR.
Why
Upstream NVIDIA gates CI through a mirror pattern: every PR is force-pushed to `refs/heads/pull-request/` by an external GitHub App when a maintainer comments `/ok to test `. The real worker workflows (branch-checks, helm-lint, branch-e2e, test-gpu, branch-kubernetes-e2e) trigger only on push to that mirror ref, and `required-ci-gates.yml` polls those workflow runs to post status checks back on the PR.
This fork inherited the gate-checker and the hint-poster but NOT the backing pieces:
So even applying the `test:e2e*` labels and successfully creating the mirror would not run anything. The plumbing has been cosmetic dead weight since fork inception.
Effect
Test plan