Reorder dmon startup so available for onload (SYN-10076)#4751
Reorder dmon startup so available for onload (SYN-10076)#4751mikemoritz wants to merge 8 commits intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4751 +/- ##
==========================================
- Coverage 97.73% 97.73% -0.01%
==========================================
Files 298 298
Lines 62352 62365 +13
==========================================
+ Hits 60941 60953 +12
- Misses 1411 1412 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
synapse/cortex.py
Outdated
| self._runStormPkgOnload(pkgdef) | ||
|
|
||
| self.runActiveTask(_runMigrations()) | ||
| await self.runActiveTask(_runMigrations()) |
There was a problem hiding this comment.
This is something that we consciously did not await during initServiceActive to allow for the Cortex to be promoted and use-able in a low-downtime upgrade path. awaiting this would cause promote() calls to now have a long delay in them. We should discuss this specifically.
There was a problem hiding this comment.
Does this warrant a leader aware bootstrap callback that we could use to differentiate starting as the leader vs being promoted?
There was a problem hiding this comment.
( or could we potentially have these all call eachother in sequence? )
There was a problem hiding this comment.
Per discussion this PR makes it so the cortex never blocks on layer migrations, and promotes it to a "protected" (new concept) syn task.
# Conflicts: # synapse/cortex.py
3 participants
No description provided.