Dev - add ruff check for unused imports F401 (SYN-10235)

pyproject.toml

@@ -142,8 +142,9 @@ select = [
     "E741", # Ambiguous variable name: {name}
     "E742", # Ambiguous class name: {name}
     "E743", # Ambiguous function name: {name}
+    "F401", # Unused imports
     "F541", # f-string without any placeholders
-    "F821",  # Undefined name {name}. {tip}
+    "F821", # Undefined name {name}. {tip}
     "RUF006", # Store a reference to the return value of {expr}.{method}
     "W191", # Indentation contains tabs
     "W291", # Trailing whitespace

scripts/doctests.py

@@ -7,7 +7,6 @@
 import re
 import sys
 import traceback
-import subprocess
 
 import yaml
 

synapse/__init__.py

@@ -22,6 +22,6 @@
 if tuple([int(x) for x in lmdb.__version__.split('.')]) < (1, 0, 0):  # pragma: no cover
     raise Exception('synapse is only supported on version >= 1.0.0 of the lmdb python module')
 
-from synapse.lib.version import version, verstring
+from synapse.lib.version import version, verstring  # noqa: F401
 # Friendly __version__ string alias
 __version__ = verstring

synapse/common.py

@@ -42,7 +42,7 @@
 import synapse.lib.msgpack as s_msgpack
 import synapse.lib.structlog as s_structlog
 
-import synapse.vendor.cpython.lib.ipaddress as ipaddress
+import synapse.vendor.cpython.lib.ipaddress as ipaddress  # noqa: F401
 import synapse.vendor.cpython.lib.http.cookies as v_cookies
 
 

synapse/cortex.py

@@ -50,59 +50,59 @@
 import synapse.lib.crypto.rsa as s_rsa
 
 # Importing these registers their commands
-import synapse.lib.stormhttp as s_stormhttp  # NOQA
-import synapse.lib.stormwhois as s_stormwhois  # NOQA
+import synapse.lib.stormhttp as s_stormhttp  # noqa: F401
+import synapse.lib.stormwhois as s_stormwhois  # noqa: F401
 
 import synapse.lib.stormtypes as s_stormtypes
 
-import synapse.lib.stormlib.aha as s_stormlib_aha  # NOQA
-import synapse.lib.stormlib.env as s_stormlib_env  # NOQA
-import synapse.lib.stormlib.gen as s_stormlib_gen  # NOQA
-import synapse.lib.stormlib.gis as s_stormlib_gis  # NOQA
-import synapse.lib.stormlib.hex as s_stormlib_hex  # NOQA
-import synapse.lib.stormlib.log as s_stormlib_log  # NOQA
-import synapse.lib.stormlib.pkg as s_stormlib_pkg  # NOQA
-import synapse.lib.stormlib.xml as s_stormlib_xml  # NOQA
-import synapse.lib.stormlib.auth as s_stormlib_auth  # NOQA
-import synapse.lib.stormlib.cell as s_stormlib_cell  # NOQA
-import synapse.lib.stormlib.imap as s_stormlib_imap  # NOQA
-import synapse.lib.stormlib.ipv6 as s_stormlib_ipv6  # NOQA
-import synapse.lib.stormlib.json as s_stormlib_json  # NOQA
-import synapse.lib.stormlib.math as s_stormlib_math  # NOQA
-import synapse.lib.stormlib.mime as s_stormlib_mime  # NOQA
-import synapse.lib.stormlib.pack as s_stormlib_pack  # NOQA
-import synapse.lib.stormlib.smtp as s_stormlib_smtp  # NOQA
-import synapse.lib.stormlib.stix as s_stormlib_stix  # NOQA
-import synapse.lib.stormlib.task as s_stormlib_task  # NOQA
-import synapse.lib.stormlib.yaml as s_stormlib_yaml  # NOQA
-import synapse.lib.stormlib.basex as s_stormlib_basex  # NOQA
-import synapse.lib.stormlib.cache as s_stormlib_cache  # NOQA
-import synapse.lib.stormlib.graph as s_stormlib_graph  # NOQA
-import synapse.lib.stormlib.index as s_stormlib_index  # NOQA
-import synapse.lib.stormlib.iters as s_stormlib_iters  # NOQA
+import synapse.lib.stormlib.aha as s_stormlib_aha  # noqa: F401
+import synapse.lib.stormlib.env as s_stormlib_env  # noqa: F401
+import synapse.lib.stormlib.gen as s_stormlib_gen  # noqa: F401
+import synapse.lib.stormlib.gis as s_stormlib_gis  # noqa: F401
+import synapse.lib.stormlib.hex as s_stormlib_hex  # noqa: F401
+import synapse.lib.stormlib.log as s_stormlib_log  # noqa: F401
+import synapse.lib.stormlib.pkg as s_stormlib_pkg  # noqa: F401
+import synapse.lib.stormlib.xml as s_stormlib_xml  # noqa: F401
+import synapse.lib.stormlib.auth as s_stormlib_auth  # noqa: F401
+import synapse.lib.stormlib.cell as s_stormlib_cell  # noqa: F401
+import synapse.lib.stormlib.imap as s_stormlib_imap  # noqa: F401
+import synapse.lib.stormlib.ipv6 as s_stormlib_ipv6  # noqa: F401
+import synapse.lib.stormlib.json as s_stormlib_json  # noqa: F401
+import synapse.lib.stormlib.math as s_stormlib_math  # noqa: F401
+import synapse.lib.stormlib.mime as s_stormlib_mime  # noqa: F401
+import synapse.lib.stormlib.pack as s_stormlib_pack  # noqa: F401
+import synapse.lib.stormlib.smtp as s_stormlib_smtp  # noqa: F401
+import synapse.lib.stormlib.stix as s_stormlib_stix  # noqa: F401
+import synapse.lib.stormlib.task as s_stormlib_task  # noqa: F401
+import synapse.lib.stormlib.yaml as s_stormlib_yaml  # noqa: F401
+import synapse.lib.stormlib.basex as s_stormlib_basex  # noqa: F401
+import synapse.lib.stormlib.cache as s_stormlib_cache  # noqa: F401
+import synapse.lib.stormlib.graph as s_stormlib_graph  # noqa: F401
+import synapse.lib.stormlib.index as s_stormlib_index  # noqa: F401
+import synapse.lib.stormlib.iters as s_stormlib_iters  # noqa: F401
 import synapse.lib.stormlib.macro as s_stormlib_macro
 import synapse.lib.stormlib.model as s_stormlib_model
-import synapse.lib.stormlib.oauth as s_stormlib_oauth  # NOQA
-import synapse.lib.stormlib.stats as s_stormlib_stats  # NOQA
-import synapse.lib.stormlib.storm as s_stormlib_storm  # NOQA
-import synapse.lib.stormlib.utils as s_stormlib_utils  # NOQA
-import synapse.lib.stormlib.vault as s_stormlib_vault  # NOQA
-import synapse.lib.stormlib.backup as s_stormlib_backup  # NOQA
-import synapse.lib.stormlib.cortex as s_stormlib_cortex  # NOQA
-import synapse.lib.stormlib.hashes as s_stormlib_hashes  # NOQA
-import synapse.lib.stormlib.quorum as s_stormlib_quorum  # NOQA
-import synapse.lib.stormlib.random as s_stormlib_random  # NOQA
-import synapse.lib.stormlib.scrape as s_stormlib_scrape   # NOQA
-import synapse.lib.stormlib.infosec as s_stormlib_infosec  # NOQA
-import synapse.lib.stormlib.project as s_stormlib_project  # NOQA
-import synapse.lib.stormlib.spooled as s_stormlib_spooled  # NOQA
-import synapse.lib.stormlib.tabular as s_stormlib_tabular  # NOQA
-import synapse.lib.stormlib.version as s_stormlib_version  # NOQA
-import synapse.lib.stormlib.easyperm as s_stormlib_easyperm  # NOQA
-import synapse.lib.stormlib.ethereum as s_stormlib_ethereum  # NOQA
-import synapse.lib.stormlib.modelext as s_stormlib_modelext  # NOQA
-import synapse.lib.stormlib.compression as s_stormlib_compression  # NOQA
-import synapse.lib.stormlib.notifications as s_stormlib_notifications  # NOQA
+import synapse.lib.stormlib.oauth as s_stormlib_oauth  # noqa: F401
+import synapse.lib.stormlib.stats as s_stormlib_stats  # noqa: F401
+import synapse.lib.stormlib.storm as s_stormlib_storm  # noqa: F401
+import synapse.lib.stormlib.utils as s_stormlib_utils  # noqa: F401
+import synapse.lib.stormlib.vault as s_stormlib_vault  # noqa: F401
+import synapse.lib.stormlib.backup as s_stormlib_backup  # noqa: F401
+import synapse.lib.stormlib.cortex as s_stormlib_cortex  # noqa: F401
+import synapse.lib.stormlib.hashes as s_stormlib_hashes  # noqa: F401
+import synapse.lib.stormlib.quorum as s_stormlib_quorum  # noqa: F401
+import synapse.lib.stormlib.random as s_stormlib_random  # noqa: F401
+import synapse.lib.stormlib.scrape as s_stormlib_scrape   # noqa: F401
+import synapse.lib.stormlib.infosec as s_stormlib_infosec  # noqa: F401
+import synapse.lib.stormlib.project as s_stormlib_project  # noqa: F401
+import synapse.lib.stormlib.spooled as s_stormlib_spooled  # noqa: F401
+import synapse.lib.stormlib.tabular as s_stormlib_tabular  # noqa: F401
+import synapse.lib.stormlib.version as s_stormlib_version  # noqa: F401
+import synapse.lib.stormlib.easyperm as s_stormlib_easyperm  # noqa: F401
+import synapse.lib.stormlib.ethereum as s_stormlib_ethereum  # noqa: F401
+import synapse.lib.stormlib.modelext as s_stormlib_modelext  # noqa: F401
+import synapse.lib.stormlib.compression as s_stormlib_compression  # noqa: F401
+import synapse.lib.stormlib.notifications as s_stormlib_notifications  # noqa: F401
 
 logger = logging.getLogger(__name__)
 stormlogger = logging.getLogger('synapse.storm')

synapse/lib/ast.py

@@ -25,7 +25,7 @@
 import synapse.lib.stormctrl as s_stormctrl
 import synapse.lib.stormtypes as s_stormtypes
 
-from synapse.lib.stormtypes import tobool, toint, toprim, tostr, tonumber, tocmprvalu, undef
+from synapse.lib.stormtypes import tobool, toprim, tostr, tonumber, tocmprvalu, undef
 
 SET_ALWAYS = 0
 SET_UNSET = 1

synapse/lib/crypto/rsa.py

@@ -2,10 +2,9 @@
 
 import cryptography.hazmat.primitives.hashes as c_hashes
 import cryptography.hazmat.primitives.serialization as c_ser
-import cryptography.hazmat.primitives.asymmetric.rsa as c_rsa
+import cryptography.hazmat.primitives.asymmetric.rsa as c_rsa  # noqa: F401
 import cryptography.hazmat.primitives.asymmetric.padding as c_padding
 
-import synapse.exc as s_exc
 import synapse.common as s_common
 import synapse.lib.msgpack as s_msgpack
 

synapse/lib/hive.py

@@ -1,10 +1,7 @@
-import asyncio
 import logging
-import collections
 
 import synapse.exc as s_exc
 import synapse.common as s_common
-import synapse.telepath as s_telepath
 
 import synapse.lib.base as s_base
 import synapse.lib.const as s_const

synapse/lib/json.py

@@ -5,7 +5,7 @@
 
 from typing import Any, BinaryIO, Callable, Iterator, Optional
 
-from synapse.vendor.cpython.lib.json import detect_encoding
+from synapse.vendor.cpython.lib.json import detect_encoding  # noqa: F401
 
 import yyjson
 

synapse/lib/nexus.py

@@ -90,7 +90,6 @@ async def __anit__(self, cell):
         await s_base.Base.__anit__(self)
 
         # avoid import cycle
-        import synapse.lib.lmdbslab as s_lmdbslab
         import synapse.lib.multislabseqn as s_multislabseqn
 
         self.cell = cell

synapse/lib/queue.py

@@ -1,5 +1,4 @@
 import asyncio
-import threading
 import collections
 
 import synapse.exc as s_exc

synapse/lib/stormlib/aha.py

@@ -1,7 +1,7 @@
 import textwrap
 
 import synapse.exc as s_exc
-import synapse.common as s_common
+
 import synapse.lib.stormtypes as s_stormtypes
 
 @s_stormtypes.registry.registerLib

synapse/lib/stormlib/auth.py

@@ -1,4 +1,3 @@
-import copy
 import asyncio
 
 import synapse.exc as s_exc

synapse/lib/stormlib/basex.py

@@ -1,5 +1,4 @@
 import synapse.exc as s_exc
-import synapse.common as s_common
 
 import synapse.lib.stormtypes as s_stormtypes
 

synapse/lib/stormlib/easyperm.py

@@ -1,5 +1,4 @@
 import synapse.exc as s_exc
-import synapse.common as s_common
 
 import synapse.lib.cell as s_cell
 import synapse.lib.stormtypes as s_stormtypes

synapse/lib/stormlib/graph.py

@@ -1,8 +1,5 @@
 import synapse.exc as s_exc
 
-import synapse.lib.config as s_config
-import synapse.lib.msgpack as s_msgpack
-import synapse.lib.schemas as s_schemas
 import synapse.lib.stormtypes as s_stormtypes
 
 USER_EDITABLE = {

synapse/lib/stormlib/imap.py

@@ -10,7 +10,6 @@
 import synapse.data as s_data
 import synapse.common as s_common
 
-import synapse.lib.coro as s_coro
 import synapse.lib.link as s_link
 import synapse.lib.stormtypes as s_stormtypes
 

synapse/lib/stormlib/iters.py

@@ -1,4 +1,3 @@
-import sys
 import asyncio
 import contextlib
 

synapse/lib/stormlib/quorum.py

@@ -1,4 +1,3 @@
-import synapse.common as s_common
 import synapse.lib.stormtypes as s_stormtypes
 
 @s_stormtypes.registry.registerLib

synapse/models/doc.py

@@ -1,4 +1,3 @@
-import synapse.exc as s_exc
 import synapse.lib.module as s_module
 
 class DocModule(s_module.CoreModule):

synapse/models/infotech.py

@@ -8,8 +8,6 @@
 import synapse.exc as s_exc
 import synapse.data as s_data
 
-import synapse.common as s_common
-
 import synapse.lib.chop as s_chop
 import synapse.lib.types as s_types
 import synapse.lib.module as s_module

synapse/telepath.py

@@ -6,7 +6,6 @@
 import ssl
 import copy
 import time
-import yaml
 import asyncio
 import logging
 import contextlib
@@ -22,7 +21,6 @@
 import synapse.lib.certdir as s_certdir
 import synapse.lib.threads as s_threads
 import synapse.lib.urlhelp as s_urlhelp
-import synapse.lib.version as s_version
 import synapse.lib.hashitem as s_hashitem
 
 logger = logging.getLogger(__name__)

synapse/tests/test_cmds_cortex.py

@@ -10,9 +10,6 @@
 
 import synapse.tests.utils as s_t_utils
 
-from synapse.tests.utils import alist
-
-
 class CmdCoreTest(s_t_utils.SynTest):
 
     async def test_storm(self):

synapse/tests/test_common.py

@@ -2,7 +2,6 @@
 import http
 import asyncio
 import logging
-import subprocess
 
 import yaml
 import aiohttp

synapse/tests/test_lib_auth.py

@@ -7,7 +7,6 @@
 import synapse.common as s_common
 import synapse.telepath as s_telepath
 
-import synapse.lib.auth as s_auth
 import synapse.lib.cell as s_cell
 import synapse.lib.lmdbslab as s_lmdbslab
 

synapse/tests/test_lib_coro.py

@@ -1,11 +1,7 @@
-import sys
-import time
 import asyncio
 import threading
 
-import synapse.exc as s_exc
 import synapse.glob as s_glob
-import synapse.common as s_common
 
 import synapse.lib.coro as s_coro
 import synapse.tests.utils as s_t_utils

synapse/tests/test_lib_jsonstor.py

@@ -1,6 +1,5 @@
 import synapse.exc as s_exc
 import synapse.lib.lmdbslab as s_lmdbslab
-import synapse.lib.jsonstor as s_jsonstor
 
 import synapse.tests.utils as s_test
 

synapse/tests/test_lib_scrape.py

@@ -1,4 +1,3 @@
-from unittest import mock
 
 import regex
 

synapse/tests/test_lib_snap.py

@@ -363,12 +363,8 @@ async def test_cortex_lift_bytype(self):
 
     async def test_clearcache(self):
 
-        # Type hinting since we dont do the type hinting
-        # properly in the Cortex anymore... :(
-        import synapse.lib.snap as s_snap
-
         async with self.getTestCore() as core:
-            async with await core.snap() as snap0:  # type: s_snap.Snap
+            async with await core.snap() as snap0:
 
                 original_node0 = await snap0.addNode('test:str', 'node0')
                 self.len(1, snap0.buidcache)
@@ -381,7 +377,7 @@ async def test_clearcache(self):
                 self.len(4, snap0.livenodes)
                 self.len(3, snap0.tagnorms)
 
-                async with await core.snap() as snap1:  # type: s_snap.Snap
+                async with await core.snap() as snap1:
                     snap1_node0 = await snap1.getNodeByNdef(('test:str', 'node0'))
                     await snap1_node0.delTag('foo.bar.baz')
                     self.notin('foo.bar.baz', snap1_node0.tags)

synapse/tests/test_lib_stormlib_cell.py

@@ -1,6 +1,5 @@
 import synapse.exc as s_exc
 
-import synapse.lib.aha as s_aha
 import synapse.lib.coro as s_coro
 import synapse.lib.const as s_const
 import synapse.lib.stormlib.cell as s_stormlib_cell

synapse/tests/test_lib_stormlib_easyperm.py

@@ -1,7 +1,6 @@
 import synapse.exc as s_exc
 
 import synapse.lib.cell as s_cell
-import synapse.lib.layer as s_layer
 
 import synapse.tests.utils as s_test
 

synapse/tests/test_lib_stormlib_iters.py

@@ -1,6 +1,5 @@
 from unittest import mock
 
-import synapse.exc as s_exc
 
 import synapse.tests.utils as s_test
 

synapse/tests/test_lib_stormlib_oauth.py

@@ -1,7 +1,6 @@
 import os
 import yarl
 import base64
-import asyncio
 import logging
 
 import synapse.exc as s_exc

synapse/tests/test_lib_stormlib_pack.py

@@ -1,5 +1,4 @@
 import synapse.exc as s_exc
-import synapse.common as s_common
 
 import synapse.tests.utils as s_test
 

synapse/tests/test_lib_stormlib_quorum.py

@@ -1,5 +1,3 @@
-import synapse.exc as s_exc
-import synapse.common as s_common
 
 import synapse.tests.utils as s_test