Skip to content

Add syntask information to SIGUSR2 output. (SYN-10353)#4728

Open
vEpiphyte wants to merge 15 commits intomasterfrom
feat_sigusr_syntasks
Open

Add syntask information to SIGUSR2 output. (SYN-10353)#4728
vEpiphyte wants to merge 15 commits intomasterfrom
feat_sigusr_syntasks

Conversation

@vEpiphyte
Copy link
Contributor

@vEpiphyte vEpiphyte commented Feb 4, 2026

This exposes additional information about tasks printed to the console. For example:

Stack for <Task pending name='Task-20' coro=<Daemon._onLinkMesg() running at /home/epiphyte/PycharmProjects/synapse/synapse/daemon.py:395> wait_for=<Future pending cb=[Task.task_wakeup()]> cb=[clone.<locals>.taskdone() at /home/epiphyte/PycharmProjects/synapse/synapse/lib/scope.py:220, <1 more>, Task._onTaskDone()]> (most recent call last):
  File "/home/epiphyte/PycharmProjects/synapse/synapse/daemon.py", line 395, in _onLinkMesg
    await func(link, mesg)
Task-20 is a syntask with the following information: iden=4054d100c903840e8a1a1e97fc6765eb name=storm root=None user=a5b9096be499b0151ee52c93585094be username=root
{'query': 'while (true) { $lib.print(`hi {$lib.repr(time, $lib.time.now())}`) '
          '$lib.time.sleep(12) }',
 'view': 'f0b57c61012e26afe3f28452fa04fad8'}

@vEpiphyte vEpiphyte marked this pull request as draft February 4, 2026 14:22
@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.73%. Comparing base (f3f571f) to head (3365198).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4728   +/-   ##
=======================================
  Coverage   97.73%   97.73%           
=======================================
  Files         298      298           
  Lines       62352    62355    +3     
=======================================
+ Hits        60941    60944    +3     
  Misses       1411     1411           
Flag Coverage Δ
linux 97.65% <100.00%> (-0.02%) ⬇️
linux_replay 93.41% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vEpiphyte vEpiphyte marked this pull request as ready for review February 4, 2026 19:36
MichaelSquires
MichaelSquires previously approved these changes Feb 4, 2026
Copy link
Contributor

@MichaelSquires MichaelSquires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no tests?

@vEpiphyte
Copy link
Contributor Author

We don't have any tests for these handlers currently.

@vEpiphyte
Copy link
Contributor Author

@MichaelSquires I should be able to write quick tests for these functions, mocking builtins.print.

@vEpiphyte vEpiphyte added this to the v2.23x.x milestone Feb 5, 2026
@vEpiphyte vEpiphyte removed this from the v2.23x.x milestone Feb 6, 2026
@vEpiphyte vEpiphyte marked this pull request as draft February 11, 2026 20:45
@vEpiphyte vEpiphyte marked this pull request as ready for review February 19, 2026 18:39
MichaelSquires
MichaelSquires previously approved these changes Feb 19, 2026
@vEpiphyte vEpiphyte added this to the v2.23x.x milestone Feb 25, 2026
MichaelSquires
MichaelSquires previously approved these changes Feb 26, 2026
@vEpiphyte vEpiphyte changed the title Add syntask information to SIGUSR2 output. Add syntask information to SIGUSR2 output. (SYN-10353) Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants