Initial open fd monitoring w/ cell write lock (SYN-10120)#4684
Initial open fd monitoring w/ cell write lock (SYN-10120)#4684
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (80.88%) is below the target coverage (97.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #4684 +/- ##
==========================================
- Coverage 97.72% 97.70% -0.02%
==========================================
Files 296 296
Lines 62151 62209 +58
==========================================
+ Hits 60736 60782 +46
- Misses 1415 1427 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: blackout <blackout@vertex.link>
|
We should disable/not start the FD monitoring if the limit is already set to unlimited. |
|
@MichaelSquires that would be safe if we assume that no one will ever change the soft limit of the process while it is running. If we do decide to bail in that case we should include in docs that monitoring isn't done if the soft limit is set to unlimited. |
No description provided.